Re: [Openvpn-devel] [PATCH v4] push-peer-info: rearrange function generating peer info

2022-09-26 Thread Gert Doering
Hi, On Mon, Sep 26, 2022 at 08:46:50AM +0200, Antonio Quartulli wrote: > On 26/09/2022 08:39, Gert Doering wrote: > > It might seem elegant, to do this with a fall-through switch/case, but > > it turns out to be not very elegant due to the restrictions on local > > variables. Also, if someone en

[Openvpn-devel] [PATCH v5 release/2.5] msvc: add branch name and commit hash to version output

2022-09-26 Thread Lev Stipakov
From: Lev Stipakov Add a simple python script which generates header with branch name and commit hash #defines. While on it, fix filename in msvc-generate.vcxproj and add proper copyright header to Makefile.mak. Signed-off-by: Lev Stipakov --- v5: - replace "detached" with "none" ("none" if

[Openvpn-devel] [PATCH] t_client: add per-instance arguments to fping

2022-09-26 Thread Gert Doering
In addition to global FPING_EXTRA_ARGS now also evaluate FPING_ARGGS_. This can be used, for example, for a test instance for "will ToS-tagged packets be sent properly?" by setting FPING_ARGS_2="-O 0x10". Signed-off-by: Gert Doering --- tests/t_client.sh.in | 5 +++-- 1 file changed, 3 insertio

[Openvpn-devel] [PATCH applied] Re: msvc: add branch name and commit hash to version output

2022-09-26 Thread Gert Doering
Acked-by: Gert Doering This is a useful feature, and after some polishing, I think this is about as good as it will get now :-) - thanks. I have not tested this at all, as I have no MSVC build environment and it will not manifest on MinGW builds. From my understanding it looks reasonable. You

[Openvpn-devel] [PATCH applied] Re: msvc: add branch name and commit hash to version output

2022-09-26 Thread Gert Doering
Acked-by: Gert Doering Same change as to master, just taking differences in config-msgc.h into account. Your patch has been applied to the release/2.5 branch. commit 8cbfd57e4ad423c807ca8ec69f88fbc0e2da5aec (release/2.5) Author: Lev Stipakov Date: Mon Sep 26 10:08:43 2022 +0300 msvc: ad