[Openvpn-devel] [PATCH v100 05/10] dco-win: add documentation to README.dco.md

2022-08-12 Thread Antonio Quartulli
Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- README.dco.md | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/README.dco.md b/README.dco.md index c38d3de3..d67f6e7e 100644 --- a/README.dco.md +++ b/README.dco.md @@ -57

[Openvpn-devel] [PATCH v100 01/10] do_open_tun: restyle "can preserve TUN" check

2022-08-12 Thread Antonio Quartulli
The current condition checking if the TUN interface was preserved is dependant on the platform being Android or not. This makes the code reasonably ugly, especially because uncrustify can't indent properly. On top of that, we will require an extra condition only for windows+DCO, which will make th

[Openvpn-devel] [PATCH v100 02/10] dco-win: introduce low-level code for handling ovpn-dco-win in Windows

2022-08-12 Thread Antonio Quartulli
Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- config-msvc.h | 2 + configure.ac| 9 +- dev-tools/special-files.lst | 1 + src/openvpn/Makefile.am | 4 +- src/openvpn/dco_inte

[Openvpn-devel] [PATCH v100 03/10] dco-win: add platform dependant check on incompatible options

2022-08-12 Thread Antonio Quartulli
Some platforms may have different constraints in terms of incompatible opions, therefore we add a function that explicitly checks those. Also, add generic option check for when ovpn-dco-win is in use. Signed-off-by: Antonio Quartulli Signed-off-by: Lev Stipakov --- src/openvpn/dco.c | 17 +

[Openvpn-devel] [PATCH v100 07/10] dco-win: ensure the DCO API is not used when running on Windows

2022-08-12 Thread Antonio Quartulli
On Windows the high level API should still use the link_socket object to read and write packets. For this reason, even if dco_installed is true, we still need to rely on the classic link_socket object. Signed-off-by: Antonio Quartulli --- src/openvpn/dco_win.c | 4 ++-- src/openvpn/forward.c |

[Openvpn-devel] [PATCH v100 04/10] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-12 Thread Antonio Quartulli
With this change it is possible to use ovpn-dco-win when running OpenVPN in client or P2P mode. Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- Changes from v3: * rename WINDOWS_DRIVER_WINDCO to WINDOWS_DRIVER_DCO * add reference string check Change

[Openvpn-devel] [PATCH v100 06/10] dco-win: update GH Actions config file

2022-08-12 Thread Antonio Quartulli
Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- .github/workflows/build.yaml | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index c89d3c8c..6bd108b9 100644 --- a/.github/workflows/build.yaml +

[Openvpn-devel] [PATCH v100 09/10] dco: properly name variables

2022-08-12 Thread Antonio Quartulli
renamed remote_addrX variables to vpn_addrX to make it clear that they refer to the address over the VPN/tunnel Signed-off-by: Antonio Quartulli --- src/openvpn/dco.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index

[Openvpn-devel] [PATCH v100 00/10] ovpn-dco: leftovers

2022-08-12 Thread Antonio Quartulli
This patchset is essentially a resending of the patches that were already on the mailing list, but were not appled yet. Some of them required extra work, while some required reordering. To make things simpler, I am resending them as a patchset, with some extra bonus patches too. I am going with

[Openvpn-devel] [PATCH v100 08/10] ovpn-dco: print some netlink messages to debug level

2022-08-12 Thread Antonio Quartulli
Netlink errors detected during dco availability detection are not really required and can confuse the user. Have them printed to the dco debug level. Signed-off-by: Antonio Quartulli --- src/openvpn/dco_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/dco_l

[Openvpn-devel] [PATCH v100 10/10] dco: move message to DCO debug level and reword a bit

2022-08-12 Thread Antonio Quartulli
This message is purely a debug message, so it should go to the appropriate log level. At the same time make it more clear. Signed-off-by: Antonio Quartulli --- src/openvpn/dco_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_

[Openvpn-devel] [PATCH 1/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-08-12 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Implement data-channel offload for FreeBSD. The implementation and flow is very similar to that of the Linux DCO support. Signed-off-by: Kristof Provost --- configure.ac | 5 + src/openvpn/Makefile.am| 1 + src/openvpn/dco.c |

[Openvpn-devel] [PATCH 2/2] Support creating iroute route entries on FreeBSD

2022-08-12 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Signed-off-by: Kristof Provost --- src/openvpn/Makefile.am | 1 + src/openvpn/dco.c| 8 +-- src/openvpn/dco_freebsd.h| 2 + src/openvpn/networking.h | 9 +++ src/openvpn/networking_freebsd.c | 101 +++

[Openvpn-devel] [PATCHv2]: FreeBSD DCO support

2022-08-12 Thread Kristof Provost via Openvpn-devel
Hi, Here's the updated version of the FreeBSD DCO patch. It should address all remarks on the userspace side of things. I'm still trying to reproduce the fragmentation issue. I've gotten Gert's additional information, but I've not yet been able to act on it. I'm fairly certain that any bug is goi

Re: [Openvpn-devel] [PATCH 1/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-08-12 Thread Kristof Provost via Openvpn-devel
Remarks inline. Mostly ACK. I’ll post an updated version soon. (I’ve also added a check for UDP in dco_check_option_conflict_ce(). On 10 Aug 2022, at 18:32, Gert Doering wrote: > On Mon, Aug 08, 2022 at 04:34:23PM +0200, Kristof Provost via Openvpn-devel > wrote: >> diff --git a/src/openvpn/dco

Re: [Openvpn-devel] [PATCH v100 01/10] do_open_tun: restyle "can preserve TUN" check

2022-08-12 Thread Lev Stipakov
Stared at the code and slightly tested on Windows. Functionality hasn't changed and code is now easier to read. Acked-by: Lev Stipakov pe 12. elok. 2022 klo 16.08 Antonio Quartulli (a...@unstable.cc) kirjoitti: > The current condition checking if the TUN interface was preserved is > dependant

Re: [Openvpn-devel] [PATCH v100 02/10] dco-win: introduce low-level code for handling ovpn-dco-win in Windows

2022-08-12 Thread Lev Stipakov
Hi, General note - this commit has no commit message and introduces a set of functions which are not yet called. Does it really make sense to split dco-win support into two commits? src/openvpn/ovpn-dco-win.h | 108 > We have ovpn_dco_linux.h and ovpn-dco-win.h. Should we unif

Re: [Openvpn-devel] [PATCH v100 02/10] dco-win: introduce low-level code for handling ovpn-dco-win in Windows

2022-08-12 Thread Lev Stipakov
Oh and also: 6>C:\Users\lev\Projects\openvpn\src\openvpn\dco.c(280,27): error C2039: 'disable_dco': is not a member of 'tuntap_options' 6>C:\Users\lev\Projects\openvpn\src\openvpn\tun.h(64): message : see declaration of 'tuntap_options' -Lev ___ Openvpn

Re: [Openvpn-devel] [PATCH v100 03/10] dco-win: add platform dependant check on incompatible options

2022-08-12 Thread Lev Stipakov
Hi, I think commit message is a bit misleading: >dco-win: add platform dependant check on incompatible options >Some platforms may have different constraints in terms of incompatible >opions, therefore we add a function that explicitly checks those. >Also, add generic option check for when ovpn-d

Re: [Openvpn-devel] [PATCH v100 05/10] dco-win: add documentation to README.dco.md

2022-08-12 Thread Lev Stipakov
Hi, +Getting started (Windows) > +- > +Getting started under windows is currently for brave people having > experience > +with windows development. You need to compile openvpn yourself and also > need > +to get the test driver installed on your system. > While I consider b

Re: [Openvpn-devel] [PATCH v100 02/10] dco-win: introduce low-level code for handling ovpn-dco-win in Windows

2022-08-12 Thread Gert Doering
Hi, On Fri, Aug 12, 2022 at 03:06:49PM +0200, Antonio Quartulli wrote: > mbuf.c mbuf.h \ > memdbg.h \ > misc.c misc.h \ > + ovpn-dco-win.h \ Can we please make this ovpn_dco_win.h, with underscores? gert -- "If was one thing all people took for granted, was conviction that