Re: [Openvpn-devel] [PATCH] Remove outdated information from ChangeLog, point at release branches.

2022-08-10 Thread Arne Schwabe
Thanks! Acked-By: Arne Schwabe ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2] dco: move availability check to the end of check_option_conflict() function

2022-08-10 Thread Frank Lichtenheld
FWIW I put this through the buildbot as a test for the new extended t_client tests on the docker workers and it caused no issues. Also ran the t_client tests on my DCO-enabled Ubuntu 22 laptop. I did not do any more specific tests. Changes look sensible to me, so Acked-By: Frank Lichtenheld On T

[Openvpn-devel] Summary of the community meeting (10th August 2022)

2022-08-10 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 10th August 2022 Time: 10:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local meeting

[Openvpn-devel] [PATCH] dco_p2p_add_new_peer: do not warn about missing default gw

2022-08-10 Thread Frank Lichtenheld
Currently we issue a message when using --ifconfig but not specifying a default gateway. This seems to be misleading, the setup will still work fine since in P2P we now send all traffic to the peer anyway. Or it might be irrelevant if all route specifications include a gateway anyway. Since it is

Re: [Openvpn-devel] [PATCH] dco_p2p_add_new_peer: do not warn about missing default gw

2022-08-10 Thread Antonio Quartulli
Hi, On 10/08/2022 11:46, Frank Lichtenheld wrote: Currently we issue a message when using --ifconfig but not specifying a default gateway. This seems to be misleading, the setup will still work fine since in P2P we now send all traffic to the peer anyway. Or it might be irrelevant if all route s

Re: [Openvpn-devel] [PATCH v5] platform: Retain CAP_NET_ADMIN when dropping privileges

2022-08-10 Thread Timo Rothenpieler
On 14/05/2022 12:37, Timo Rothenpieler wrote: On Linux, when dropping privileges, interaction with the network configuration, such as tearing down routes or ovpn-dco interfaces will fail when --user/--group are used. This patch sets the CAP_NET_ADMIN capability, which grants the needed privilege

[Openvpn-devel] [PATCH v6] Don't "undo" ifconfig on exit if it wasn't done

2022-08-10 Thread Max Fillinger
When running with --ifconfig-noexec, OpenVPN does not execute ifconfig, but on exit, it still tries to "undo" the configuration it would have done. This patch fixes it by extracting an undo_ifconfig() function from close_tun(). The undo function is called before close_tun(), but only if --ifconfig-

Re: [Openvpn-devel] [PATCH 1/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-08-10 Thread Gert Doering
(Re-sending, as the first one had a .png attached which exceeded what sourceforge is willing to forward) Hi, as promised, here's test results and code review. Test results: - running openvpn over TCP gives me a kernel panic - this is not so nice... (see attached .png from the vmware console

[Openvpn-devel] [PATCH applied] Re: Remove outdated information from ChangeLog, point at release branches.

2022-08-10 Thread Gert Doering
Patch has been applied to the master branch. commit 3cb40b22ae6133eb7b000347abbe392c3dbabeac Author: Gert Doering Date: Wed Aug 10 10:47:01 2022 +0200 Remove outdated information from ChangeLog, point at release branches. Signed-off-by: Gert Doering Acked-by: Arne Schwabe

Re: [Openvpn-devel] [PATCH 1/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-08-10 Thread Kristof Provost via Openvpn-devel
Thanks! On 10 Aug 2022, at 18:32, Gert Doering wrote: > Test results: > > - running openvpn over TCP gives me a kernel panic - this is not so >nice... (see attached .png from the vmware console) - userland seems >to assume "kernel can do TCP", kernel panics on "if !udp, panic()" >(so

Re: [Openvpn-devel] [PATCH] dco_p2p_add_new_peer: do not warn about missing default gw

2022-08-10 Thread Gert Doering
Hi, On Wed, Aug 10, 2022 at 11:46:05AM +0200, Frank Lichtenheld wrote: > diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c > index 4f40255e..8aa7e896 100644 > --- a/src/openvpn/dco.c > +++ b/src/openvpn/dco.c > @@ -438,10 +438,6 @@ dco_p2p_add_new_peer(struct context *c) > } > r