[Openvpn-devel] Summary of the community meeting (29th June 2022)

2022-06-29 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 29th June 2022 Time: 10:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local meeting t

[Openvpn-devel] [PATCH v3] dco: let open_tun_generic handle the DCO case

2022-06-29 Thread Antonio Quartulli
open_tun_generic already contains the logic required to find a device name when not specified b the user. For this reason the DCO case can easily leverage on function and avoid code duplication. Signed-off-by: Antonio Quartulli --- Changes from v2: * do not abuse the dynamic_name variable. Rathe

[Openvpn-devel] [PATCH v4] dco: let open_tun_generic handle the DCO case

2022-06-29 Thread Antonio Quartulli
open_tun_generic already contains the logic required to find a device name when not specified b the user. For this reason the DCO case can easily leverage on function and avoid code duplication. Signed-off-by: Antonio Quartulli --- Changes from v3: * explicitly mention "DCO" in message when DCO

Re: [Openvpn-devel] [PATCH v4] Don't "undo" ifconfig on exit if it wasn't done

2022-06-29 Thread Antonio Quartulli
Hi, On 31/05/2022 17:17, Max Fillinger wrote: When running with --ifconfig-noexec, OpenVPN does not execute ifconfig, but on exit, it still tries to "undo" the configuration it would have done. This patch fixes it by extracting an undo_ifconfig() function from close_tun(). The undo function is c

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Arne Schwabe
Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: Hi, Here's the most recent version of the FreeBSD DCO patch. This is based on top of the dco branch, at 480fa1c983aba9b0790ea94df209e1686f08336b. Relatedly, the kernel side of that support has just landed in FreeBSD's repo: https:

[Openvpn-devel] [Patch v5] Don't "undo" ifconfig on exit if it wasn't done

2022-06-29 Thread Max Fillinger
When running with --ifconfig-noexec, OpenVPN does not execute ifconfig, but on exit, it still tries to "undo" the configuration it would have done. This patch fixes it by extracting an undo_ifconfig() function from close_tun(). The undo function is called before close_tun(), but only if --ifconfig-

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Kristof Provost via Openvpn-devel
On 29 Jun 2022, at 17:15, Arne Schwabe wrote: > Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: >> Hi, >> >> Here's the most recent version of the FreeBSD DCO patch. >> This is based on top of the dco branch, at >> 480fa1c983aba9b0790ea94df209e1686f08336b. >> >> Relatedly, the kerne

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Arne Schwabe
Am 29.06.2022 um 19:40 schrieb Kristof Provost: On 29 Jun 2022, at 17:15, Arne Schwabe wrote: Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: Hi, Here's the most recent version of the FreeBSD DCO patch. This is based on top of the dco branch, at 480fa1c983aba9b0790ea94df209e16

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Kristof Provost via Openvpn-devel
On 29 Jun 2022, at 21:08, Arne Schwabe wrote: > Am 29.06.2022 um 19:40 schrieb Kristof Provost: >> On 29 Jun 2022, at 17:15, Arne Schwabe wrote: >>> Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: Hi, Here's the most recent version of the FreeBSD DCO patch. This