[Openvpn-devel] [PATCH applied] Re: remove foreign_option() call for IPv6 DNS servers

2022-05-27 Thread Gert Doering
Acked-by: Gert Doering Indeed, this is inside an WIN32/ANDROID block, which does not need/use foreign options for DHCP. Out it goes. Trivial otherwise :-) Your patch has been applied to the master branch. commit 2c4cf1a6490b875a4c666d781c30f1033f739118 Author: Heiko Hund Date: Fri May 27 03

[Openvpn-devel] [PATCH applied] Re: remove dead foreign-option parsing code

2022-05-27 Thread Gert Doering
Acked-by: Gert Doering Trivial. Inside #if 0, has been like that since the dawn of times, so really nobody can ever miss that one. Your patch has been applied to the master branch. commit ccdd7096ae9a5fe6f07451f525cbdd40885f3acc Author: Heiko Hund Date: Fri May 27 03:24:55 2022 +0200 r

[Openvpn-devel] [PATCH applied] Re: rename foreign_option() and move it up

2022-05-27 Thread Gert Doering
Acked-by: Gert Doering Slightly less trivial, but "git show --color-moved=zebra" helps visualize that it's indeed moved 1:1 and just gets a new name. Your patch has been applied to the master branch. commit 2c2b22b370b239ae8311e8152ab0bb81cc66fe29 Author: Heiko Hund Date: Fri May 27 03:24:56

[Openvpn-devel] [PATCH] include unistd.h for _exit(2) declaration

2022-05-27 Thread Heiko Hund
Signed-off-by: Heiko Hund --- src/openvpn/error.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/error.h b/src/openvpn/error.h index 972619fe..76308560 100644 --- a/src/openvpn/error.h +++ b/src/openvpn/error.h @@ -33,6 +33,8 @@ #if _WIN32 #include +#else +#include #endi

Re: [Openvpn-devel] [PATCH] include unistd.h for _exit(2) declaration

2022-05-27 Thread Gert Doering
Hi, On Fri, May 27, 2022 at 01:34:11PM +0200, Heiko Hund wrote: > Signed-off-by: Heiko Hund > --- > src/openvpn/error.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/openvpn/error.h b/src/openvpn/error.h > index 972619fe..76308560 100644 > --- a/src/openvpn/error.h > +++ b/src/

Re: [Openvpn-devel] [PATCH] include unistd.h for _exit(2) declaration

2022-05-27 Thread Heiko Hund
Hi Gert On Freitag, 27. Mai 2022 13:40:57 CEST Gert Doering wrote: > is included by "syshead.h" already today, with a nice > HAVE_UNISTD_H wraper (thus, not depending on a "if it's not WIN32, > it surely must have unistd.h" assumption). > > So I wonder what issue this fixes? I see no compile ti