Re: [Openvpn-devel] [PATCH 1/4] mtcp: Handle multi_create_instance() returning NULL

2022-05-17 Thread Antonio Quartulli
Hi all, On 16/05/2022 21:32, Arne Schwabe wrote: Am 16.05.2022 um 20:56 schrieb Kristof Provost via Openvpn-devel: From: Kristof Provost multi_create_instance() can fail (i.e. return NULL). multi_create_instance_tcp() is ready for this, but called multi_assign_peer_id() without first checkin

Re: [Openvpn-devel] [PATCH 4/4] Set (DCO) timeouts as well for p2p mode

2022-05-17 Thread Antonio Quartulli
Hi, On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: From: Kristof Provost Signed-off-by: Kristof Provost --- src/openvpn/init.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 0d991ba4..701749cd 100644 --- a/s

Re: [Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-05-17 Thread Antonio Quartulli
Hi, On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: From: Kristof Provost We must create the peer before we can dco_set_peer or dco_new_key. On the other hand, we must first process options, because those may change our peer id and we should create the peer with the correct id.

Re: [Openvpn-devel] [PATCH 2/4] rework do_up() for correct order of DCO operations

2022-05-17 Thread Kristof Provost via Openvpn-devel
On 17 May 2022, at 15:28, Antonio Quartulli wrote: > On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: >> From: Kristof Provost >> >> We must create the peer before we can dco_set_peer or dco_new_key. >> On the other hand, we must first process options, because those may >> change our

Re: [Openvpn-devel] [PATCH 4/4] Set (DCO) timeouts as well for p2p mode

2022-05-17 Thread Kristof Provost via Openvpn-devel
On 17 May 2022, at 15:25, Antonio Quartulli wrote: > Hi, > > On 16/05/2022 20:56, Kristof Provost via Openvpn-devel wrote: >> From: Kristof Provost >> >> Signed-off-by: Kristof Provost >> --- >> src/openvpn/init.c | 15 +++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/src

[Openvpn-devel] [PATCH] pre-commit: uncrustify based on staged changes

2022-05-17 Thread Heiko Hund
Previously the generated patch was based on the file(s) in the working directory. This is a problem if you have not to be commited changes there and these changes fix formatting issues that exist in the staging area. This effectively circumventes the script from rejecting the commit. An example: