Re: [Openvpn-devel] [PATCH applied] Re: CI: github actions: keep pdb in artifacts

2022-02-21 Thread Gert Doering
Hi, On Sat, Sep 11, 2021 at 06:50:31PM +0200, Gert Doering wrote: > SoB added, no further tests. > > Your patch has been applied to the master branch. > > commit 9da733751ce80b2226ef19923365bd3102cfbd47 > Author: Ilya Shipitsin > Date: Thu Aug 26 15:02:21 2021 +0500 As requested by Lev, also

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-21 Thread Lev Stipakov
Let's start from the beginning. I'll start two new threads (master and 2.5) and Ilya could ack them. Ilya, to ack please reply on those threads with following line: Acked-by: Firstname Lastname su 20. helmik. 2022 klo 19.31 Gert Doering (g...@greenie.muc.de) kirjoitti: > > Hi, > > On Sun, Feb

Re: [Openvpn-devel] [PATCH master+release/2.5] error.c: use correct API to get error description on Windows

2022-02-21 Thread Lev Stipakov
We had a long discussion with ordex about this patch and came to the conclusion that error printing is currently broken on Windows and needs a proper fixing. Why is it broken? - the bug that my patch fixes - we use Windows's GetLastError to get Windows last error code and with that strerror to g

[Openvpn-devel] [PATCH v2] msvc: adjust build options to harden binaries

2022-02-21 Thread Lev Stipakov
From: Lev Stipakov - enable hardware-enforced stack protection on compatible hardware/software (/CETCOMPAT linker option) - hash object files with SHA256 (/ZH:SHA_256 compiler option) - enable SDL. The required to add _CRT_NONSTDC_NO_DEPRECATE _CRT_SECURE_NO_WARNINGS _WINSOCK_DE

[Openvpn-devel] [PATCH v2 release/2.5] msvc: adjust build options to harden binaries

2022-02-21 Thread Lev Stipakov
From: Lev Stipakov - enable hardware-enforced stack protection on compatible hardware/software (/CETCOMPAT linker option) - hash object files with SHA256 (/ZH:SHA_256 compiler option) - enable SDL. The required to add _CRT_NONSTDC_NO_DEPRECATE _CRT_SECURE_NO_WARNINGS _WINSOCK_DE

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-21 Thread Илья Шипицин
Lev, I see two new messages in this thread. Please clarify what do you want me to do? пн, 21 февр. 2022 г. в 13:59, Lev Stipakov : > Let's start from the beginning. > > I'll start two new threads (master and 2.5) and Ilya could ack them. > > Ilya, to ack please reply on those threads with followi

[Openvpn-devel] [PATCH] doc: cleanup for --data-ciphers and related

2022-02-21 Thread Frank Lichtenheld
- Fix various formatting inconsistencies - Explain what NCP means before using it. - Also replace some of the usages of NCP with the clearer "cipher negotiation". Signed-off-by: Frank Lichtenheld --- doc/man-sections/protocol-options.rst | 34 +-- 1 file changed, 17 ins

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-21 Thread Lev Stipakov
Reply to both of them with the line (remove ">"): > Acked-by: Ilya Shipitsin if you think that you could ack both of those patches. ma 21. helmik. 2022 klo 13.17 Илья Шипицин (chipits...@gmail.com) kirjoitti: > > Lev, I see two new messages in this thread. Please clarify what do you want > me

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-21 Thread Илья Шипицин
sorry, it does not look like "2 new threads". also, I'm not sure patchwork will be able to pick 2 ack from 1 thread. I'm not motivated to run in circles from you to Gert and back. if you can find someone more motivated, I'll appreciate that. пн, 21 февр. 2022 г. в 17:02, Lev Stipakov : > Reply t

Re: [Openvpn-devel] [PATCH master+release/2.5] error.c: use correct API to get error description on Windows

2022-02-21 Thread Selva Nair
Hi On Mon, Feb 21, 2022 at 4:24 AM Lev Stipakov wrote: > We had a long discussion with ordex about this patch and came to the > conclusion that error printing is currently broken on Windows and > needs a proper fixing. > > +1 > What we propose: > > - M_ERRNO prints only C runtime errors on al

[Openvpn-devel] [PATCH] Fix --mtu-disc maybe|yes on Linux.

2022-02-21 Thread Gert Doering
--mtu-disc (on Linux) needs two components to work: - setsockopt() with IP_MTU_DISCOVER or IPV6_MTU_DISCOVER - "extended error reporting" (setsockopt(IP_RECVERR) and then via mtu.c/format_extended_socket_error()) to react on "packet too big" errors on sendto() / sendmsg() Some conf

Re: [Openvpn-devel] [PATCH] doc: cleanup for --data-ciphers and related

2022-02-21 Thread David Sommerseth
On 21/02/2022 12:19, Frank Lichtenheld wrote: - Fix various formatting inconsistencies - Explain what NCP means before using it. - Also replace some of the usages of NCP with the clearer "cipher negotiation". Signed-off-by: Frank Lichtenheld --- doc/man-sections/protocol-options.rst | 34 +

Re: [Openvpn-devel] [PATCH] doc: cleanup for --data-ciphers and related

2022-02-21 Thread Arne Schwabe
Am 21.02.22 um 12:19 schrieb Frank Lichtenheld: - Fix various formatting inconsistencies - Explain what NCP means before using it. - Also replace some of the usages of NCP with the clearer "cipher negotiation". Signed-off-by: Frank Lichtenheld --- doc/man-sections/protocol-options.rst | 34

Re: [Openvpn-devel] [PATCH] doc: cleanup for --data-ciphers and related

2022-02-21 Thread Frank Lichtenheld
> Arne Schwabe hat am 21.02.2022 21:23 geschrieben: > Am 21.02.22 um 12:19 schrieb Frank Lichtenheld: > > @@ -191,7 +191,8 @@ configured in a compatible way between both the local > > and remote side. > > > > For servers, the first cipher from ``cipher-list`` that is also > > suppor