[Openvpn-devel] [PATCH] keyingmaterialexporter.c: include strings.h

2022-02-03 Thread Antonio Quartulli
strcasecmp() was initially declared in string.h and subsequently moved to strings.h. For historical reasons it still exists in string.h, but would require _DEFAULT_SOURCE to be defined. Due to the above, just include strings.h as currently dictated by the manpage. Fixes the following warning: ke

Re: [Openvpn-devel] [PATCH] keyingmaterialexporter.c: include strings.h

2022-02-03 Thread Gert Doering
Hi, On Thu, Feb 03, 2022 at 09:26:20AM +0100, Antonio Quartulli wrote: > strcasecmp() was initially declared in string.h and subsequently moved > to strings.h. For historical reasons it still exists in string.h, but > would require _DEFAULT_SOURCE to be defined. > > Due to the above, just include

Re: [Openvpn-devel] [PATCH] keyingmaterialexporter.c: include strings.h

2022-02-03 Thread Antonio Quartulli
Hi, On 03/02/2022 09:32, Gert Doering wrote: Hi, On Thu, Feb 03, 2022 at 09:26:20AM +0100, Antonio Quartulli wrote: strcasecmp() was initially declared in string.h and subsequently moved to strings.h. For historical reasons it still exists in string.h, but would require _DEFAULT_SOURCE to be d

Re: [Openvpn-devel] [PATCH] pkcs11_openssl.c: check EVP_get_digestbyname() != NULL

2022-02-03 Thread Antonio Quartulli
Hi, On 27/01/2022 01:14, selva.n...@gmail.com wrote: From: Selva Nair Reported-by: Arne Schwabe Signed-off-by: Selva Nair Acked-by: Antonio Quartulli -- Antonio Quartulli ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net htt

[Openvpn-devel] [PATCH applied] Re: pkcs11_openssl.c: check EVP_get_digestbyname() != NULL

2022-02-03 Thread Gert Doering
Have not tested, but looks reasonable. Your patch has been applied to the master branch. commit fb60a5a9d0da982df0edeac8287aa5ee55f4e79a Author: Selva Nair Date: Wed Jan 26 19:14:10 2022 -0500 pkcs11_openssl.c: check EVP_get_digestbyname() != NULL Signed-off-by: Selva Nair Ack

[Openvpn-devel] [PATCH applied] Re: keyingmaterialexporter.c: include strings.h

2022-02-03 Thread Gert Doering
Acked-by: Gert Doering FreeBSD manpage confirms that should be used. Insanity, but well. Your patch has been applied to the master and release/2.5 branch (bugfix, even if not very critical). commit d93a2b6160759d42d3fbaecc7fc868a7120221ef (master) commit 2d31bf20dcffaab00a677bab06c8fe3816b660

[Openvpn-devel] [PATCH applied] Re: Remove link_mtu parameter when running up/down scripts

2022-02-03 Thread Gert Doering
Acked-by: Gert Doering "Because it makes sense". Client-side and server-side tested (I do not have any scripts that look at link_mtu, I have other scripts that might be upset). Code change is simple enough. For reference, this was 16/21 in v1 of the series, and got a NAK for "missing update t

Re: [Openvpn-devel] [PATCH v3 09/14] Add mtu paramter to --fragment and change fragment calculation

2022-02-03 Thread Gert Doering
Hi, On Sat, Jan 01, 2022 at 05:25:27PM +0100, Arne Schwabe wrote: > Instead relying on the link_mtu_dynamic field and its calculation > in the frame struct, add a new field max_fragment_size and add > a calculation of it similar to mssfix. > > Also whenever mssfix value is calculated, we also wan

Re: [Openvpn-devel] [PATCH v3 09/14] Add mtu paramter to --fragment and change fragment calculation

2022-02-03 Thread Gert Doering
Hi, On Thu, Feb 03, 2022 at 02:30:38PM +0100, Gert Doering wrote: > and server pushes this: > > 2022-02-03 14:28:24 PUSH: Received control message: 'PUSH_REPLY,route > 10.194.0.0 255.255.0.0,route-ipv6 fd00:abcd:194::/48,tun-ipv6,route > 10.194.2.1,topology net30,ping 10,ping-restart 30,compres

Re: [Openvpn-devel] [PATCH v3 12/14] Replace TUN_MTU_SIZE with frame->tun_mtu

2022-02-03 Thread Gert Doering
Hi, On Sat, Jan 01, 2022 at 05:25:30PM +0100, Arne Schwabe wrote: > This always uses the configured MTU size instead relying on the calculated > MTU size. This one, applied on top of "everything up to 11/14 v3" does not compile. It removes the TUN_MTU_SIZE() macro, but there is still "frame_fina

Re: [Openvpn-devel] [PATCH v3 09/14] Add mtu paramter to --fragment and change fragment calculation

2022-02-03 Thread Gert Doering
Hi, On Thu, Feb 03, 2022 at 05:39:32PM +0100, Gert Doering wrote: > Maybe this is a transient effect which will disappear when all of the > patchset is in... trying this next. This is transient. 12/14 ("Replace TUN_MTU_SIZE with frame->tun_mtu") makes the code return to "the ifconfig mtu is 1500

[Openvpn-devel] [PATCH v2 1/2] crypto: move validation logic from cipher_get to cipher_valid

2022-02-03 Thread Antonio Quartulli
With cipher validation performed in cipher_get(), a cipher is never returned in any case if some check fails. This prevents OpenVPN from operating on all ciphers provided by the SSL library, like printing them to the user. Move the validation logic to cipher_valid() so that checks are performed o

[Openvpn-devel] [PATCH v2 2/2] crypto: move OpenSSL specific FIPS check to its backend

2022-02-03 Thread Antonio Quartulli
Our crypto API already provides a function performing a validity check on the specified ciphername. The OpenSSL counterpart also checks for the cipher being FIPS-enabled. This API is cipher_valid(). Extend it so that it can provide a reason whenever the cipher is not valid and use it in crypto.c.