Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-12 Thread Lev Stipakov
Hi, I tested yesterday on Windows 10 and today also on Windows 7 and 8.1. - /30 subnet (OpenVPN Cloud as server) - /24 subnet (openvpn2) with redirect-gateway def1. Tested that ping works and traffic goes through the tunnel. Also our QA tested this (not exactly this one, but my original patch

Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-12 Thread Gert Doering
Hi, On Fri, Nov 12, 2021 at 02:33:31PM +0200, Lev Stipakov wrote: > How about we apply my original patch (0 for /28 and -1 for the rest) > to 2.5 and this one to master? I tend to go for "make it simple and consistent", which would make this "0 everywhere, if it breaks, the option is still availa

[Openvpn-devel] [PATCH v6] [OSSL 3.0] Allow loading of non default providers

2021-11-12 Thread Arne Schwabe
This allows OpenVPN to load non-default providers. This is mainly useful for loading the legacy provider with --providers legacy default Patch v4: use spaces to seperate providers, unload providers. Patch v5: General cleanup, rename option to --providers, add option to usage() and add an

[Openvpn-devel] [PATCH applied] Re: Allow loading of non default providers

2021-11-12 Thread Gert Doering
Acked-by: Gert Doering I tool Selva's patch, and added my own for the change v5->v6 (which is really just moving the #ifdef to the other side of the block, so the options.c code is always compiled in). Tested on 1.1 ("unsurprisingly, no change") and 3.0 builds ("my test cases against 2.3 server

Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-12 Thread Selva Nair
> > How about we apply my original patch (0 for /28 and -1 for the rest) > to 2.5 and this one to master? I do not see the logic behind that. If there are any platforms where 0 (network address) is not acceptable, it's unlikely to work for /30 as well. /31 is special, /30 is not. And, based on you

[Openvpn-devel] [PATCH applied] Re: Use network address for emulated DHCP server as a default

2021-11-12 Thread Gert Doering
Acked-by: Gert Doering Not sure, really, why this did not get enough traction 5 years ago... so thanks for pushing it :-) - and I understand that Selva did not want to ACK it. I have not tested it, just stared a bit at the code (fine) and test compiled on MinGW (also fine). Getting rid of the i