Re: [Openvpn-devel] [PATCH v2] Add building man page on Windows

2021-08-26 Thread Samuli Seppänen
Hi, I smoke-tested this on Linux and it does not break anything (docutils installed or not). Results of Windows testing below. Il 24/08/21 16:46, Lev Stipakov ha scritto: From: Lev Stipakov Use rst2html to build html from rst. Ignore errors, this is not fatal and affects only MSI build. Mo

[Openvpn-devel] [PATCH] CI: github actions: keep "pdb" in artifacts

2021-08-26 Thread Ilya Shipitsin
"pdb" files are important for example, for BinSkim analysis. Let us keep them --- .github/workflows/build.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index b2c16449..4c963114 100644 --- a/.github/workflows/build.yaml +++ b/.g

[Openvpn-devel] [PATCH v3] Add building man page on Windows

2021-08-26 Thread Lev Stipakov
From: Lev Stipakov Use rst2html to build html from rst. Ignore errors, this is not fatal and affects only MSI build. Modify MSVC GitHub Actions to install python3/rst2html and add html man page to artifacts. Signed-off-by: Lev Stipakov --- v3: - replace "python3" with "python" v2: - cha

[Openvpn-devel] [PATCH v4] Add building man page on Windows

2021-08-26 Thread Lev Stipakov
From: Lev Stipakov Use rst2html to build html from rst. Ignore errors, this is not fatal and affects only MSI build. Modify MSVC GitHub Actions to install python3/rst2html and add html man page to artifacts. Signed-off-by: Lev Stipakov --- v4: - really replace "python3" with "python" v3:

Re: [Openvpn-devel] [PATCH] CI: github actions: keep "pdb" in artifacts

2021-08-26 Thread Lev Stipakov
Patch is missing SOB line, but I guess this can be fixed by the committer, if needed? Checked https://github.com/chipitsine/openvpn/actions/runs/1108264158 so that PDBs are indeed stored as artifacts. Acked-by: Lev Stipakov ___ Openvpn-devel mailing

Re: [Openvpn-devel] [PATCH v4] Add building man page on Windows

2021-08-26 Thread Samuli Seppänen
Il 25/08/21 19:47, Lev Stipakov ha scritto: From: Lev Stipakov Use rst2html to build html from rst. Ignore errors, this is not fatal and affects only MSI build. Modify MSVC GitHub Actions to install python3/rst2html and add html man page to artifacts. Signed-off-by: Lev Stipakov --- v4:

Re: [Openvpn-devel] [PATCH] CI: github actions: keep "pdb" in artifacts

2021-08-26 Thread Илья Шипицин
Sorry, I missed "signed off by". Please add during commit On Thu, Aug 26, 2021, 3:20 PM Lev Stipakov wrote: > Patch is missing SOB line, but I guess this can be fixed by the > committer, if needed? > > Checked https://github.com/chipitsine/openvpn/actions/runs/1108264158 > so that PDBs are indee

Re: [Openvpn-devel] [PATCH] route.c: pass the right parameter to IN6_IS_ADDR_UNSPECIFIED

2021-08-26 Thread Arne Schwabe
Am 26.08.21 um 08:17 schrieb Antonio Quartulli: > IN6_IS_ADDR_UNSPECIFIED on most systems is defined as a macro that > expects a struct in6_addr* argument. > > In one instance we are passing the right address but using a wrong type. > Fix this invocation by properly passing the right pointer. > >