[Openvpn-devel] [PATCH] GitHub Actions: fix MSVC builds

2021-08-01 Thread Lev Stipakov
From: Lev Stipakov By reasons remain unknown, MSVC GitHub Actions started to fail after some irrelevant change. While problem is also reproduced on my GitHub fork, I couldn't reproduce it locally. Despiteadding debug logging to GitHub Actions it is not clear what went wrong: ##[debug]Exit code

[Openvpn-devel] [PATCH applied] Re: Remove --ncp-disable option

2021-08-01 Thread Gert Doering
Stared at the code for a while... this all looks very reasonable, except for removal of that warning -msg(M_WARN, "--cipher is not set. Previous OpenVPN version defaulted to " -"BF-CBC as fallback when cipher negotiation failed in this case. " -"If you need this fa

[Openvpn-devel] [PATCH applied] Re: GitHub Actions: fix MSVC builds

2021-08-01 Thread Gert Doering
Acked-by: Gert Doering I do not need to understand this... but it's basically upgrading build prerequisites only for GH Actions, which does not affect anything else = if Lev says it's good, so I believe :-) Your patch has been applied to the master branch. commit 852d98efbd9dde09ff6dfedac19e5

[Openvpn-devel] [PATCH applied] Re: contrib/vcpkg-ports: remove openssl port

2021-08-01 Thread Gert Doering
Acked-by: Gert Doering Since we never wanted to maintain our own patch, this is welcome. I have left out the hunk to .github/workflows/build.yaml, as that has been superseded by commit de8871f86db. (I have not tested this in any way, just looked at the patch to see which files it modifies and w

[Openvpn-devel] [PATCH applied] Re: Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-08-01 Thread Gert Doering
Acked-by: Gert Doering I've taken David's ACK on v2, compared the changes to v3 (some of the nitpicks David has pointed out, .pem/.key/.crt changes, plus language changes by Richard), and added my own ACK based on that. Integrated Richard's "6 minor improvements" - thanks :-) Your patch has bee

Re: [Openvpn-devel] [PATCH] Change CTR DRBG update function call to new mbedtls 2.16.0 API

2021-08-01 Thread Gert Doering
Hi, On Fri, Apr 02, 2021 at 03:26:23PM +0200, Max Fillinger wrote: > From: Uipko Berghuis > > In mbedtls 2.16.0 mbedtls_ctr_drbg_update() changed to > mbedtls_ctr_drbg_update_ret(). Change the function name and handle > the new return value error code. Going through patches in patchwork right n