Re: [Openvpn-devel] [PATCH v2 9/9] Support NCP in pure P2P VPN setups

2021-07-27 Thread Antonio Quartulli
Hi, On 20/05/2021 17:11, Arne Schwabe wrote: > Currently P2P mode of OpenVPN is on of the few places that cannot negotiate > modern OpenVPN features. This becomes more and more problematic since P2P and > P2MP code diverge more and more and also the lack of switching to more > advanced features li

Re: [Openvpn-devel] [PATCH] Fix OpenVPN querying user/password if auth-token with user expires

2021-07-27 Thread Antonio Quartulli
Hi, On 22/07/2021 18:24, Arne Schwabe wrote: > The problematic behaviour happens when start a profile without > auth-user-pass and connect to a server that pushes auth-token > When the auth token expires OpenVPN asks for auth User and password > again. > > The problem is that the auth_user_pass_s

Re: [Openvpn-devel] [PATCH] Fix OpenVPN querying user/password if auth-token with user expires

2021-07-27 Thread Antonio Quartulli
Hi, On 27/07/2021 15:42, Antonio Quartulli wrote: > Hi, > > On 22/07/2021 18:24, Arne Schwabe wrote: >> The problematic behaviour happens when start a profile without >> auth-user-pass and connect to a server that pushes auth-token >> When the auth token expires OpenVPN asks for auth User and pas

[Openvpn-devel] [PATCH applied] Re: Fix argv leaks in add_route() and add_route_ipv6()

2021-07-27 Thread Gert Doering
Thanks for your patch. I have not seriously tested (just a basic compile test) as it is "obviously correct" for that special case. I have extended the commit message a bit to explain why the change was done (this is what Antonio was talking about - "help the casual reader who wants to understand

Re: [Openvpn-devel] [PATCH v2] Allow PKCS#11 uri to be used as --cert and --key file names

2021-07-27 Thread Selva Nair
It seems no one is interested in this to elicit a review.. I thought this would be a nifty feature ;) On Sun, May 9, 2021 at 9:32 PM wrote: > From: Selva Nair > > v2 changes > - do not allow so-path embedded in cert and key uri > - add --pkcs11-engine option to optionally specify the >

[Openvpn-devel] [PATCH] Use more C99 initialization in add_route/add_route_ipv6().

2021-07-27 Thread Gert Doering
This gets rid of a few #ifdef and also removes the need for commit a11bea18b1c93 (argv is only initialized after the early exit check on RT_DEFINED). Signed-off-by: Gert Doering --- src/openvpn/route.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) di

Re: [Openvpn-devel] [PATCH v2] Allow PKCS#11 uri to be used as --cert and --key file names

2021-07-27 Thread mike tancsa
That would be VERY handy to have for our use case     ---Mike On 7/27/2021 10:56 AM, Selva Nair wrote: > > It seems no one is interested in this to elicit a review.. I thought > this would be a nifty feature ;) > > On Sun, May 9, 2021 at 9:32 PM > wrote: > > From

Re: [Openvpn-devel] [PATCH v2] Allow PKCS#11 uri to be used as --cert and --key file names

2021-07-27 Thread Gert Doering
Hi, On Tue, Jul 27, 2021 at 11:18:53AM -0400, mike tancsa wrote: > That would be VERY handy to have for our use case So could you *test* it? I'm happy to stare at the code a bit, but have no test environment to verify that it actually works. Thus, test reports by actual users are more than welc