[Openvpn-devel] [PATCH] Add github actions

2021-06-08 Thread Arne Schwabe
dummy0 gives strange errors on the Ubuntu 16 runner on github actions because dummy already exist, so use a more unique ovpn-dummy0 name instead. Github actions are a good alternative to travis-ci, which futrure is questionable at the moment without payment. The github actions also allows buildin

Re: [Openvpn-devel] [PATCH] Implement Windows CA template match for Crypto-API selector

2021-06-08 Thread Selva Nair
Hi, > > > > +static const CRYPT_OID_INFO * > > > +find_oid(DWORD keytype, const void *key, DWORD groupid, bool > > > +fallback) { > > > +const CRYPT_OID_INFO *info = NULL; > > > + > > > +/* force resolve from local as first step */ > > > +if (groupid != CRYPT_HASH_ALG_OID_GROUP_ID && >

Re: [Openvpn-devel] [PATCH] Implement Windows CA template match for Crypto-API selector

2021-06-08 Thread Selva Nair
Hi, Oh, it seems I replied to the stale thread (version 1). As Gert mentioned, please include a version tag and use --in-reply-to to keep it threaded in the next iteration. Some additional comments below. On Fri, Jun 4, 2021 at 10:41 AM Heiko Wundram wrote: > > The certificate selection proces

[Openvpn-devel] UNSUBSCRIBE

2021-06-08 Thread John Aron
___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] UNSUBSCRIBE

2021-06-08 Thread Antonio Quartulli
Please follow this URL to unsubscribe: https://lists.sourceforge.net/lists/listinfo/openvpn-devel Regards, On 08/06/2021 18:08, John Aron wrote: >   > > > > ___ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sou

[Openvpn-devel] [PATCH] Silence warning about format string in check_ca_required

2021-06-08 Thread Arne Schwabe
clang does not like if the format argument of printf like function is not a string literal: warning: format string is not a string literal (potentially insecure) Use "%s" as string literal to silence the warning. Signed-off-by: Arne Schwabe --- src/openvpn/options.c | 2 +- 1 file changed, 1 i

Re: [Openvpn-devel] [PATCH] Silence warning about format string in check_ca_required

2021-06-08 Thread Antonio Quartulli
Hi, On 08/06/2021 21:43, Arne Schwabe wrote: > clang does not like if the format argument of printf like function > is not a string literal: > > warning: format string is not a string literal (potentially insecure) > > Use "%s" as string literal to silence the warning. > > Signed-off-by: Arne S

Re: [Openvpn-devel] [PATCH] Silence warning about format string in check_ca_required

2021-06-08 Thread Selva Nair
Hi On Tue, Jun 8, 2021 at 3:44 PM Arne Schwabe wrote: > clang does not like if the format argument of printf like function > is not a string literal: > > warning: format string is not a string literal (potentially insecure) > > Use "%s" as string literal to silence the warning. > Format string

[Openvpn-devel] [PATCH v2] Silence warning about format string in check_ca_required

2021-06-08 Thread Antonio Quartulli
From: Arne Schwabe clang does not like if the format argument of printf like function is not a string literal (or constant): warning: format string is not a string literal (potentially insecure) Make the format string constant to silence the warning. Signed-off-by: Arne Schwabe Signed-off-by:

Re: [Openvpn-devel] [PATCH] Add github actions

2021-06-08 Thread Lev Stipakov
Looks good, all builds passed: https://github.com/schwabe/openvpn/actions/runs/918610289 If those two patches will be acked (none of them touches C code) and merged: - https://patchwork.openvpn.net/patch/1815/ - https://patchwork.openvpn.net/patch/1850/ one could add MSVC github actions as wel

Re: [Openvpn-devel] [PATCH] Add github actions

2021-06-08 Thread Gert Doering
Hi, On Tue, Jun 08, 2021 at 05:24:34PM +0200, Arne Schwabe wrote: > +steps: > + - name: Install dependencies > +run: sudo apt update && sudo apt install -y mingw-w64 libtool > automake autoconf man2html unzip > + - name: Checkout ovpn-dco-win > +uses: actions/checkou

[Openvpn-devel] [PATCH applied] Re: Add github actions

2021-06-08 Thread Gert Doering
Your patch has been applied to the master branch. commit b4f658dfb018dcb22962eaa8b45ddd45c55f3003 Author: Arne Schwabe Date: Tue Jun 8 17:24:34 2021 +0200 Add github actions Signed-off-by: Arne Schwabe Acked-by: Lev Stipakov Message-Id: <20210608152434.1403999-1-a...@rfc2