> -_stprintf_s(szTitle, _countof(szTitle), TEXT("%s v%s"), szFunctionName,
> TEXT(PACKAGE_VERSION));
> +_stprintf_s(szTitle, _countof(szTitle), TEXT("%") TEXT(PRIsLPTSTR)
> TEXT("v%") TEXT(PRIsLPTSTR),
Just a note that a whitespace is (still) missing before "v%", but it
is fixed in subse
Have not tested this, just stared a bit at the code. Did not "fix"
the "%s v%s" issue Lev pointed out as this will be fixed in the next
patch... thanks.
(I do wonder if "support ansi builds" is really something we want, if
that makes the code so complicated - "always UNICODE" seems to be much
si
Looks good, compiled and tested with MSVC.
Note that this needs to be merged after "[PATCH 3/3 v2] Print format
spec changes for tapctl and openvpnmscia".
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https
Change looks reasonable and matches the explanation. Not tested.
Your patch has been applied to the master branch.
commit 890225c1783d0f11b2092495ff902a46d7d0d4cd
Author: Selva Nair
Date: Wed May 26 18:49:19 2021 -0400
Replace TEXT(__FUNCTION__) by __FUNCTION__ in openvpnmscia.c
Si
Hi
On Thu, May 27, 2021 at 3:11 AM Gert Doering wrote:
>
> Have not tested this, just stared a bit at the code. Did not "fix"
> the "%s v%s" issue Lev pointed out as this will be fixed in the next
> patch... thanks.
>
> (I do wonder if "support ansi builds" is really something we want, if
> tha
