Re: [Openvpn-devel] [PATCH] Add connection_established as state in tls_multi->context_auth

2021-05-13 Thread Antonio Quartulli
Hi, On 02/05/2021 00:35, Arne Schwabe wrote: > the socket_info->connection_establish is set through > link_socket_set_outgoing_addr when we reach FULL_SYNC. This patch > introduces a new state in context_auth that replaces the > connection_established state for TLS connections. This make the state

Re: [Openvpn-devel] [PATCH 4/9] Add missing free_key_ctx for auth_token

2021-05-13 Thread Antonio Quartulli
Hi, On 12/05/2021 15:15, Arne Schwabe wrote: > This is is a small memory leak as this key is only leaked once > per server start. > > Signed-off-by: Arne Schwabe The leak can indeed be seen with valgrind when running the server with --auth-gen-token: ==23481== HEAP SUMMARY: ==23481== in us

Re: [Openvpn-devel] [PATCH 9/9] Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-05-13 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I was in the process of reviewing this patch when I found that protonmail had changed most of the git '+' to '-', see below. I have reported a bug to protonmail. Anyway, I can see a few typos and some other odd errors. Hopefully, protonmail wi

Re: [Openvpn-devel] [PATCH 9/9] Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-05-13 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I used sed to create my own reply .. comments inline. ‐‐‐ Original Message ‐‐‐ On Wednesday, 12 May 2021 14:15, Arne Schwabe wrote: > This is meant to give new users a quickstart for a useable OpenVPN > setup. Our own documentation

Re: [Openvpn-devel] [PATCH 9/9] Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-05-13 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, missed one.. ‐‐‐ Original Message ‐‐‐ On Thursday, 13 May 2021 22:48, tincantech via Openvpn-devel wrote: > Hi, > > I used sed to create my own reply .. > > comments inline. > > ‐‐‐ Original Message ‐‐‐ > On Wednesday, 12 May