Am 22.04.21 um 01:49 schrieb Antonio Quartulli:
> From: Antonio Quartulli
>
> A fingerprint is not expected to contains any blank (white space),
> howeveri, the parser routine will still attempt parsing the octect
> and ignore the space.
>
> This means that a fingerprint like
> 5
> :F0:A8:75:70
From: Arne Schwabe
Changes from v2:
- moved event definitions to event.h
- removed READ/WRITE_SHIFT and use EVENT_READ/WRITE
- removed ifdefs around *_SHIFTS definitions in event.h
Changes from v1:
- fixed typ0s
- extended comment
- moved *_SHIFT definition to openvpn.h
- made READ/WRITE events
Am 26.04.21 um 15:26 schrieb Antonio Quartulli:
> From: Arne Schwabe
>
> Changes from v2:
> - moved event definitions to event.h
> - removed READ/WRITE_SHIFT and use EVENT_READ/WRITE
> - removed ifdefs around *_SHIFTS definitions in event.h
>
> Changes from v1:
> - fixed typ0s
> - extended comme
Hi,
unfortunately something is not right.
Additional tests showed that something broke after applying this patch.
Will debug and provide a new version.
Regards,
On 26/04/2021 15:26, Antonio Quartulli wrote:
> From: Arne Schwabe
>
> Changes from v2:
> - moved event definitions to event.h
> - r
Your patch has been applied to the master branch.
That said, I find this function pretty insane, tbh. Parsing a sequence
of double-digit hex bytes should be doable in half the lines of code,
and without needing to copy bytes to temp buffers to pass to scanf()...
(https://stackoverflow.com/questio
From: Antonio Quartulli
Changes from v3:
- re-introduce READ/WRITE_SHIFT because they are different from EVENT_READ/WRITE
- define also EVENT_READ/WRITE using READ/WRITE_SHIFT
Changes from v2:
- moved event definitions to event.h
- removed READ/WRITE_SHIFT and use EVENT_READ/WRITE
- removed ifde
The existing code was doing far too much work for too little
gain - copying the string segment for scanf(), checking extra
for spaces, making the result quite unreadable.
Verify each segment with (short-circuited) isxdigit() checks,
then feed directly to scanf(), which will stop parsing on ':'
or
https://developer.android.com/about/versions/android-4.2
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Hi,
On 26/04/2021 19:44, Gert Doering wrote:
> The existing code was doing far too much work for too little
> gain - copying the string segment for scanf(), checking extra
> for spaces, making the result quite unreadable.
>
> Verify each segment with (short-circuited) isxdigit() checks,
> then fe
