Re: [Openvpn-devel] [PATCH v2 1/2] In init_ssl, open the correct CRL path pre-chroot

2021-04-14 Thread Arne Schwabe
> >> +if (options->chroot_dir == NULL || in_chroot || >> options->crl_file_inline) >> +{ >> +tls_ctx_reload_crl(new_ctx, options->crl_file, >> options->crl_file_inline); >> +} >> +else >> +{ >> +struct gc_arena gc = gc_new(); >> +

Re: [Openvpn-devel] [PATCH v2 1/2] In init_ssl, open the correct CRL path pre-chroot

2021-04-14 Thread Antonio Quartulli
Hi, Thanks a lot for reworking your contribution! On 12/04/2021 18:45, Max Fillinger wrote: > When using the chroot option, the init_ssl function can be called before > entering the chroot or, when OpenVPN receives a SIGHUP, afterwards. This > commit ensures that OpenVPN tries to open the corre

Re: [Openvpn-devel] [PATCH v2 1/2] In init_ssl, open the correct CRL path pre-chroot

2021-04-14 Thread Antonio Quartulli
On 14/04/2021 11:29, Arne Schwabe wrote: > >> >>> +if (options->chroot_dir == NULL || in_chroot || >>> options->crl_file_inline) >>> +{ >>> +tls_ctx_reload_crl(new_ctx, options->crl_file, >>> options->crl_file_inline); >>> +} >>> +else >>> +

Re: [Openvpn-devel] [PATCH v2 2/2] Abort if CRL file can't be stat-ed in init_ssl

2021-04-14 Thread Antonio Quartulli
On 12/04/2021 18:45, Max Fillinger wrote: > Now that the path for the CRL file is handled correctly when using > chroot, there's no good reason for the file to be inaccessible during > init_ssl(). > > This commit ensures that the CRL file is accessed successfully at least > once, which fixes a

Re: [Openvpn-devel] [PATCH 1/2] Fix IPv4 default gateway with multiple route tables

2021-04-14 Thread Antonio Quartulli
Hi, On 13/04/2021 14:20, Vladislav Grishenko wrote: > Current default gateway selection for zero destignation address just little typ0: destiGnation > dumps and parses all the routing tables. If any of non-main table > with default route comes first, wrong default gateway can be picked. > Since