[Openvpn-devel] [PATCH applied] Re: Check return values in md_ctx_init and hmac_ctx_init

2021-02-14 Thread Gert Doering
Your patch has been applied to the master branch. Whitespace has been adjusted in a totally space-neutral way. As instructed by the master of whitespace distribution. (On the patch itself: only compile-tested, but it seems to be "obviously correct", according to the man pages) commit 0714ed804e

Re: [Openvpn-devel] [PATCH v2] Allow running a default configuration with TLS libraries without BF-CBC

2021-02-14 Thread Gert Doering
Hi, On Mon, Jan 25, 2021 at 01:43:30PM +0100, Arne Schwabe wrote: > Modern TLS libraries might drop Blowfish by default or distributions > might disable Blowfish in OpenSSL/mbed TLS. We still signal OCC > options with BF-CBC compatible strings. To avoid requiring BF-CBC > for this, special this on

[Openvpn-devel] [PATCH applied] Re: Implement client side handling of AUTH_PENDING message

2021-02-14 Thread Gert Doering
Your patch has been applied to the master branch. I'm not sure I understand the code, though. It receives the new timeout from the server (that is easy), but then caps it by "hand_window", which is never increased - so the maximum timeout stays at "60", unless increased manually on the client. W

[Openvpn-devel] [PATCH applied] Re: Introduce management client state for AUTH_PENDING notifications

2021-02-14 Thread Gert Doering
Your patch has been applied to the master branch. As this is not depending on 03/11, I've applied it out of sequence. One typo fixed ("techhnically"). Test run on the client, unsurprisingly no breakage - I have nothing that excercises the new code yet, but it still looks very reasonable :-) co

[Openvpn-devel] [PATCH applied] Re: Add S_EXITCODE flag for openvpn_run_script to report exit code

2021-02-14 Thread Gert Doering
Your patch has been applied to the master branch. Again, out of sequence, as this does not depend on 03/11 or 05/11. Lightly tested and stared at the code a bit. Added a line break before a "{"... commit 04876274b5059f4c27b1f481fd92ff5e8ab15f1c Author: Arne Schwabe Date: Mon Jan 25 13:56:23 2

Re: [Openvpn-devel] [PATCH v2 07/11] Refactor extract_var_peer_info into standalone function and add ssl_util.c

2021-02-14 Thread Gert Doering
Hi, On Mon, Jan 25, 2021 at 01:56:24PM +0100, Arne Schwabe wrote: > Our "natural" place for this function would be ssl.c but ssl.c has a lot of > dependencies on all kinds of other compilation units so including ssl.c into > unit tests is near impossible currently. Instead create a new file ssl_ut