Re: [Openvpn-devel] [PATCH] Make OPENVPN_PLUGIN_ENABLE_PF failures FATAL

2021-01-23 Thread Gert Doering
Hi, On Fri, Jan 22, 2021 at 08:02:42AM +0100, Arne Schwabe wrote: > I agree to make this "fixed" in a way that doesn't involve refactoring > of pf code that is later removed anyway. I don't think the refactoring > early affects this. It has been probably broken even earlier. So I got myself nerds

[Openvpn-devel] [PATCH applied] Re: Make OPENVPN_PLUGIN_ENABLE_PF failures FATAL

2021-01-23 Thread Gert Doering
Patch has been applied to the master and release/2.5 branch. release/2.4 has different code and does not fail, so does not need the patch. commit 6a0c51baaa4d2b329183601ec35d3d16f127519e (master) commit cbbdcd4f97bb19e5be6c11cf94397b38e869a0ee (release/2.5) Author: Gert Doering Date: Thu Jan 21

Re: [Openvpn-devel] [PATCH] Make OPENVPN_PLUGIN_ENABLE_PF failures FATAL

2021-01-23 Thread Gert Doering
Hi, (while technically in the wrong mail thread for the "should PF stay?" discussion, this is still interesting) On Fri, Jan 22, 2021 at 07:39:31AM +, tincanteksup wrote: > I agree that a VPN should focus on its task and not try to be a firewall. > > I do use the PF plugin but it is of litt

[Openvpn-devel] [PATCH applied] Re: clean up / rewrite sample-plugins/defer/simple.c

2021-01-23 Thread Gert Doering
Patch has been applied to the master, release/2.5 and release/2.4 branch. I have fixed the whitespace issue pointed out by Arne, and a few others that uncrustify wanted fixed (a few TABs have escaped, and one bracked was misaligned). commit 452e016cba977cb1c109e74977029b9c0de33de2 (master) commit

Re: [Openvpn-devel] [PATCH 1/1] Exit management interface loop early on receiving 'remote MOD' message.

2021-01-23 Thread Gert Doering
Hi, On Wed, Jul 03, 2019 at 03:50:41PM +0100, Daniel Kaldor wrote: > OpenVPN using management interface and running with > 'management-query-remote' in the config will wait for a 'remote MOD' > or 'remote ACCEPT' message before continuing with connection. > > Logs indicate that this stage of the