Re: [Openvpn-devel] Community meetings in December 2020

2020-12-15 Thread Samuli Seppänen
Il 11/12/20 01:48, tincanteksup ha scritto: > Please discuss and resolve the fate of the OpenVPN-Legacy-Service for > Windows. > > Ref: https://community.openvpn.net/openvpn/ticket/1344 > > Official status of deprecation/removal requested. > > > ___ >

[Openvpn-devel] [PATCH 2/2] Fix condition to generate session keys

2020-12-15 Thread Arne Schwabe
For --nobind clients OpenVPN reuses the context and tls_multi structs of the previous clients and does not rerun the connect scripts on connect. But since it is a new client connection, the key_id is 0 and we postpone the key generation but it will never happen. This commit changes postponing the

[Openvpn-devel] [PATCH 1/2] Move context_auth from context_2 to tls_multi

2020-12-15 Thread Arne Schwabe
Some code currently is doing weird workarounds to figure out that side as side effect from other variables in tls_multi. Signed-off-by: Arne Schwabe --- src/openvpn/forward.c| 4 ++-- src/openvpn/multi.c | 24 src/openvpn/openvpn.h| 14 -- src/o

[Openvpn-devel] [PATCH] Skip DHCP renew with Wintun adapter

2020-12-15 Thread Domagoj Pensa
Wintun does not support DHCP. Running DHCP renew with Wintun adapter fails with a logged warning. Fixed so that DHCP renewing is called only for TAP-Windows6 adapters. --- src/openvpn/tun.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[Openvpn-devel] [PATCH] Fix too early argv freeing when registering DNS

2020-12-15 Thread Domagoj Pensa
When registering DNS on Windows, argv is freed after being used in first ipconfig command (/flushdns). Then same argv is used uninitialized in next ipconfig command (/registerdns) causing heap exception and subprocess crash. As a consequence second command is never executed and locked netcmd sema

Re: [Openvpn-devel] [PATCH] Fix too early argv freeing when registering DNS

2020-12-15 Thread Gert Doering
Hi, On Tue, Dec 15, 2020 at 06:16:00PM +0100, Domagoj Pensa wrote: > When registering DNS on Windows, argv is freed after being used in first > ipconfig command (/flushdns). > > Then same argv is used uninitialized in next ipconfig command (/registerdns) > causing heap exception and subprocess cr

[Openvpn-devel] [PATCH] Remove 1 second delay before running netsh

2020-12-15 Thread Domagoj Pensa
When running various netsh commands before each 1 second sleep is added. As more netsh commands are run, especially for Wintun adapters, that can add to a noticable delayed connecting time. This should be safe. No problems were found in tests and all netsh commands executed properly with delay rem

Re: [Openvpn-devel] [PATCH] Fix too early argv freeing when registering DNS

2020-12-15 Thread Selva Nair
Hi On Tue, Dec 15, 2020 at 12:37 PM Gert Doering wrote: > Hi, > > On Tue, Dec 15, 2020 at 06:16:00PM +0100, Domagoj Pensa wrote: > > When registering DNS on Windows, argv is freed after being used in first > > ipconfig command (/flushdns). > > > > Then same argv is used uninitialized in next ipc

[Openvpn-devel] [PATCH applied] Re: Fix too early argv freeing when registering DNS

2020-12-15 Thread Gert Doering
Thanks. As already said, all of a sudden it is very obvious why it is crashing here... somewhat annoying that this wasn't noticed before 2.5.0 release, though. I've stared-at-code, and tested this on Win10 (ubuntu 18 / mingw build) with a config with --register-dns. Without the patch, crash, with