Acked-by: Gert Doering
"obviously correct" and a reasonable change.
Just a quick client side test (passed).
Your patch has been applied to the master branch.
commit 0d5aab889b0209cab9bb65f8bebf2adab5b1ff52
Author: Arne Schwabe
Date: Fri Oct 23 13:34:27 2020 +0200
Inline function tls_ge
Hi,
On Fri, Oct 23, 2020 at 01:34:28PM +0200, Arne Schwabe wrote:
> Make options.c only set xmit_hold when port_share is active to least
> document this dependency. I have not actually tested if this dependency
> is actually true (or if port_share could work without xmit_hold).
I'm not sure I und
Acked-by: Gert Doering
Change brings this more in line with other code parts, so easier
to understand.
Your patch has been applied to the master branch.
commit 2c8a9877617727438cdd874ecd38c04adebf53ad
Author: Arne Schwabe
Date: Fri Oct 23 13:34:29 2020 +0200
Align reliable_free with oth
Acked-by: Gert Doering
I have not verified the OpenSSL and pkcs11 free() functions, but the
changes to our source tree (event_free() etc.) are consistent and make
the code easier to read.
Passed a client side test (for good measure).
Your patch has been applied to the master branch.
commit cb7
Acked-by: Gert Doering
I can see why this initalization was put there, initially, to
make clear "P_DATA_V2 is not enabled by default" - but since we do
not do this for all other "do not enable this $bool by default"
initializations either, it is indeed an oddball and confuses more
than it helps.
Acked-by: Gert Doering
Looked at the changes (look good), saw that a few #ifdefs are now
"ENABLE_MANAGEMENT", so compiled with default settings and with
--disable-management. Both passed compile + t_client tests.
I have not specifically tested management functionality - I do not
have a server t
