Hi,
> +if (msg->domains[0]) {
Curly bracket could go to the next line, but @cron2 could fix that.
do_dns_domain_service() duplicates code from do_dns_service(), but
putting everything into one function will make it harder to read.
Compiled and tested on MSVC/Win10 - with that and ADAPTER_DO
Your patch has been applied to the master and release/2.5 branch.
I have not tested it, but at least test compiled on MinGW/Ubuntu 18.04,
and slightly stared at the code. Whitespace fixed as instructed :-)
commit 70882f3e40df1c70c553b8c22c747b468d5a0dc7 (master)
commit 7d7bb0c9ba0594809a88979848
Hi,
On Thu, Sep 24, 2020 at 4:57 AM Lev Stipakov wrote:
> Hi,
>
> > When there are no IPv6 DNS published, the adapter state is not
> > sanitized and might contain IPv6 DNS server from a previous session.
>
> In this case, shouldn't the "set dns" call below overwrite the previous
> value?
> > n
On 27/09/2020 20:46, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Trac #1079
>
> Signed-off-by: Selva Nair
> ---
> doc/man-sections/server-options.rst | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/doc/man-sections/server-options.rst
> b/doc/man-s
Thanks, documentation clarification is always welcome. I have added
formatting to --auth-user-pass as instructed (and rewrapped the
paragraph slightly to avoid overlong lines in the .rst)
Your patch has been applied to the master and release/2.5 branch.
commit 66ad8727935a371e237a5bada142c9f5f4
Hi,
On Sun, Sep 20, 2020 at 06:27:38PM +0300, Lev Stipakov wrote:
> From: Lev Stipakov
>
> ADAPTER_DOMAIN_SUFFIX is an openvpn3 replacement for
> DOMAIN, which is used there for split-dns. This is pushed by
> modern Access Server.
>
> This change improves compatibility between OpenVPN
> communi
