[Openvpn-devel] [PATCH applied] Re: options: don't leak inline'd key material in logfile

2020-07-18 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code (clever macro!) and tested :-) - now I see 2020-07-18 09:39:52 us=800872 ca_file = '[INLINE]' 2020-07-18 09:39:52 us=800880 cert_file = '[INLINE]' 2020-07-18 09:39:52 us=800886 priv_key_file = '[INLINE]' what used to be actual file content. Thanks fo

[Openvpn-devel] [PATCH applied] Re: Remove --no-iv

2020-07-18 Thread Gert Doering
Acked-by: Gert Doering I have taken this one out of sequence (it is intended to go after the --no-replay patch), because *this* one is simple, and the other one is quite a bit above my pay grade - plus it modifies stuff that Arne is working on (the frame adjustment stuff), so that needs much more

Re: [Openvpn-devel] [PATCH 6/9] Remove ENABLE_OCC #define

2020-07-18 Thread Gert Doering
Hi, On Fri, Jul 17, 2020 at 03:47:36PM +0200, Arne Schwabe wrote: > Commit 037669f3dd already made occ being unconditionally on. This commit > only removes the #ifdefs > > Signed-off-by: Arne Schwabe This generally looks good, and does what it says on the tin, so Acked-By: Gert Doering I hav