Re: [Openvpn-devel] [PATCH 1/2] Add --bind-dev option.

Hi, reading this more closely at merging/testing time, I do have a change request... On Fri, Jun 26, 2020 at 08:49:44PM +0200, Maximilian Wilhelm wrote: > +#ifdef TARGET_LINUX > +else if (streq (p[0], "bind-dev") && p[1]) > +{ > +VERIFY_PERMISSION (OPT_P_SOCKFLAGS); > +opt

Re: [Openvpn-devel] [PATCH 1/2] Add --bind-dev option.

Anno domini 2020 Gert Doering scripsit: Hi, > reading this more closely at merging/testing time, I do have a change > request... > > On Fri, Jun 26, 2020 at 08:49:44PM +0200, Maximilian Wilhelm wrote: > > +#ifdef TARGET_LINUX > > +else if (streq (p[0], "bind-dev") && p[1]) > > +{ > > +

[Openvpn-devel] [PATCH v2] "VRF support on Linux" / --bind-dev support

Hi, once again, this time with added error handling in the setsockopt(). Sorry for missing this before. Best Max ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v2 1/2] Add --bind-dev option.

From: Maximilian Wilhelm This options allows the user to specify a network device the OpenVPN process should use when making a connection or binding to an address. This translates in setting the SO_BINDTODEVICE option to the corresponding socket (on Linux). When for example using VRFs on

[Openvpn-devel] [PATCH v2 2/2] Documentation for --bind-dev / VRFs on Linux

From: Maximilian Wilhelm Signed-off-by: Maximilian Wilhelm --- doc/man-sections/vrf.rst | 75 1 file changed, 75 insertions(+) create mode 100644 doc/man-sections/vrf.rst diff --git a/doc/man-sections/vrf.rst b/doc/man-sections/vrf.rst new file

[Openvpn-devel] [PATCH applied] Re: Add --bind-dev option.

Acked-by: Gert Doering Your patch has been applied to the master branch. I have stared at the code (looks reasonable) and run t_client tests on Linux and FreeBSD (pass, no major surprise). I have not actually tested the functionality, because I do not have a test rig with VRF (or multiple ethe

[Openvpn-devel] [PATCH] Fix 'engine' unit test on FreeBSD (specifically 'not GNU make')

The rules to generate $(builddir)/openssl.cnf from $(srcdir)/openssl.cnf.in only worked for GNU Make. BSD make needs the rules more explicit, and the target must not have a directory specification (fixes commit 542c69c37). Signed-off-by: Gert Doering --- tests/unit_tests/engine-key/Makefile.am

[Openvpn-devel] [PATCH] Linux: do not change --txqueuelen OS default if not configured.

Remove default setting of "set txqueuelen to 100". This default dates back to the "pre git" times (before 2005) and might have been beneficial back then - nowadays, the Linux default is 500, and thus reducing(!) txqueuelen by-default can cause TX packet drops on the tun interface, and that's bad f

[Openvpn-devel] [PATCH 2/2] Log a note if someone wants to set a MTU below 1280 on IPv6

--- src/openvpn/tun.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 3ef79b2f..67d7664e 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -238,6 +238,10 @@ do_set_mtu_service(const struct tuntap *tt, const short family, const int m

[Openvpn-devel] [PATCH 1/2] Unified success messages for setting mtu

--- src/openvpn/tun.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 18cdf38d..3ef79b2f 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -251,7 +251,7 @@ do_set_mtu_service(const struct tuntap *tt, const short family, c

Re: [Openvpn-devel] [PATCH] Linux: do not change --txqueuelen OS default if not configured.

Am 29.06.20 um 20:04 schrieb Gert Doering: > Remove default setting of "set txqueuelen to 100". This default dates > back to the "pre git" times (before 2005) and might have been beneficial > back then - nowadays, the Linux default is 500, and thus reducing(!) > txqueuelen by-default can cause TX

[Openvpn-devel] [PATCH applied] Re: Linux: do not change --txqueuelen OS default if not configured.

Patch has been applied to the master branch. (I claim to have tested this before sending to the list :-) ) commit 3ef858b3d63c61be2f473a8dc5f1f79fa09a85d8 Author: Gert Doering Date: Mon Jun 29 20:04:05 2020 +0200 Linux: do not change --txqueuelen OS default if not configured. Signed

Re: [Openvpn-devel] [PATCH 1/2] Unified success messages for setting mtu

Hi, On Mon, Jun 29, 2020 at 09:09:29PM +0200, Christopher Schenk wrote: > diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c > index 18cdf38d..3ef79b2f 100644 > --- a/src/openvpn/tun.c > +++ b/src/openvpn/tun.c > @@ -251,7 +251,7 @@ do_set_mtu_service(const struct tuntap *tt, const short > family

[Openvpn-devel] [Patch][New-man] Update --txqueuelen default setting (Now OS default)

Signed-off-by: Richard Bonhomme --- doc/man-sections/advanced-options.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/man-sections/advanced-options.rst b/doc/man-sections/advanced-options.rst index dbf7799c..9b96e406 100644 --- a/doc/man-sections/advanced-options.rst

Re: [Openvpn-devel] [Patch][New-man] Update --txqueuelen default setting (Now OS default)

Hi, On Tue, Jun 30, 2020 at 12:08:39AM +0100, Richard Bonhomme wrote: > Signed-off-by: Richard Bonhomme > --- > doc/man-sections/advanced-options.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/man-sections/advanced-options.rst > b/doc/man-sections/advanced-opt