[Openvpn-devel] [PATCH applied] Re: Implement sending AUTH_PENDING challenges to clients

2020-06-20 Thread Gert Doering
Your patch has been applied to the master branch. I have fixed a few typos in doc/management-notes.txt while at it ("virant" -> "variant"). commit 1114b985dffaf7b2dcb04dfced5397562bb6606a Author: Arne Schwabe Date: Wed May 20 00:00:03 2020 +0200 Implement sending AUTH_PENDING challenges t

[Openvpn-devel] [PATCH applied] Re: Implement forwarding client CR_RESPONSE messages to management

2020-06-20 Thread Gert Doering
Your patch has been applied to the master branch. Fixed a typo in doc/management-notes.txt ("sequentiality" was meant to be exactly this, not "sequentially"). Stared a bit at the code and ran basic t_client tests, but no real testing and no real review. commit 06498f21cdf051b0643606efda96b27b3c3

[Openvpn-devel] [PATCH] Convert plugin/auth-pam.c from stderr logging to plugin_log().

2020-06-20 Thread Gert Doering
More recent OpenVPN APIs pass a function pointer for a logging function (plugin_log()) to plugins. Using this will make the plugin logs appear wherever openvpn logs to - file, syslog, stderr. This patch converts plugin/auth-pam.c "fairly mechanically" to use this new API. Real errors are logged

[Openvpn-devel] [PATCH] Add deferred authentication support to plugin-auth-pam

2020-06-20 Thread Gert Doering
If OpenVPN signals deferred authentication support (by setting the internal environment variable "auth_control_file"), do not wait for PAM stack to finish. Instead, the privileged PAM process returns RESPONSE_DEFER via the control socket, which gets turned into OPENVPN_PLUGIN_FUNC_DEFERRED towards

Re: [Openvpn-devel] [PATCH] Add deferred authentication support to plugin-auth-pam

2020-06-20 Thread Gert Doering
Hi, On Sat, Jun 20, 2020 at 06:22:06PM +0200, Gert Doering wrote: > If OpenVPN signals deferred authentication support (by setting the > internal environment variable "auth_control_file"), do not wait > for PAM stack to finish. Instead, the privileged PAM process > returns RESPONSE_DEFER via the

[Openvpn-devel] [PATCH] Change timestamps in file-based logging to ISO 8601 time format.

2020-06-20 Thread Gert Doering
Replace existing ctime() output which is hard to sort and compare with ISO 8601 / RFC 3399 "-MM-DD hh:mm:dd" format for file-based logging (stderr or --log file). RFC 3399 5.6 permits use of a space for full-date-full-time separation, which is used to enhance readability. Sylog or --machine-r

[Openvpn-devel] [PATCH] Depreciation warning for --topology net30 on servers with IPv4 pools.

2020-06-20 Thread Gert Doering
IPv4 pool handling needs lots of extra code to deal with "topology net30", so we want to remove that combination in a future release. Warn people about this in 2.5 so nobody is hit by this as a surprise. Client- and ifconfig-support for net30 will stay, as "just net30" is not what brings maintena

Re: [Openvpn-devel] [PATCH] Depreciation warning for --topology net30 on servers with IPv4 pools.

2020-06-20 Thread Arne Schwabe
Am 20.06.20 um 20:05 schrieb Gert Doering: > IPv4 pool handling needs lots of extra code to deal with "topology net30", > so we want to remove that combination in a future release. > > Warn people about this in 2.5 so nobody is hit by this as a surprise. > > Client- and ifconfig-support for net30

Re: [Openvpn-devel] [PATCH] Change timestamps in file-based logging to ISO 8601 time format.

2020-06-20 Thread Arne Schwabe
Am 20.06.20 um 19:23 schrieb Gert Doering: > Replace existing ctime() output which is hard to sort and compare > with ISO 8601 / RFC 3399 "-MM-DD hh:mm:dd" format for file-based > logging (stderr or --log file). > > RFC 3399 5.6 permits use of a space for full-date-full-time separation, > whic

[Openvpn-devel] [PATCH applied] Re: Change timestamps in file-based logging to ISO 8601 time format.

2020-06-20 Thread Gert Doering
Patch has been applied to the master branch. I have corrected the commit message (yes, --machine-readable-output) and the "*tm" whitespacing. commit ff063b6f19e035da56fbf49c891e6376543b391d Author: Gert Doering Date: Sat Jun 20 19:23:03 2020 +0200 Change timestamps in file-based logging t

[Openvpn-devel] [PATCH applied] Re: Depreciation warning for --topology net30 on servers with IPv4 pools.

2020-06-20 Thread Gert Doering
Patch has been applied to the master branch. commit 02a0332084f0dc08e39067cc6fd68abb77a03c47 Author: Gert Doering Date: Sat Jun 20 20:05:32 2020 +0200 Depreciation warning for --topology net30 on servers with IPv4 pools. Signed-off-by: Gert Doering Acked-by: Arne Schwabe