[Openvpn-devel] [PATCH applied] Re: pool: add support for ifconfig-pool-persist with IPv6 only

2020-06-07 Thread Gert Doering
Acked-by: Gert Doering Much nicer code than in v4 :-) Stared-at-code, and ran the t_client and t_server tests with ipv4-only, ipv4+ipv6 and ipv6-only pools (ipv4-only is something I never wanted to do again... :-) ). Tested pool mishandling ("corrupt" and "out-of-bounds" v4+v6 addresses, mismat

Re: [Openvpn-devel] [PATCH v4 7/7] ipv6-pool: get rid of size constraint

2020-06-07 Thread Gert Doering
Hi, On Sat, May 30, 2020 at 02:06:00AM +0200, Antonio Quartulli wrote: > o->ifconfig_ipv6_pool_defined = true; > -o->ifconfig_ipv6_pool_base = > -add_in6_addr( o->server_network_ipv6, 0x1000 ); > +o->ifconfig_ipv6_pool_base = add_in6_addr(o->server_network_ipv6

[Openvpn-devel] [PATCH applied] Re: route: warn on IPv4 routes installation when no IPv4 is configured

2020-06-07 Thread Gert Doering
Acked-by: Gert Doering "because it makes sense" :-) Tested on the client side (only) because this is really independent of client/server setup. Nicely warns if (and only if) a route for IPv4 or IPv6 is encountered without a previous ifconfig/ifconfig-ipv6. Your patch has been applied to the m

Re: [Openvpn-devel] [PATCH v6 2/3] crypto_openssl: add initialization to pick up local configuration

2020-06-07 Thread Gert Doering
Hi, > diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c > index 4ac77fde..fd57edd2 100644 > --- a/src/openvpn/crypto_openssl.c > +++ b/src/openvpn/crypto_openssl.c > @@ -149,6 +149,11 @@ crypto_init_lib_engine(const char *engine_name) > void > crypto_init_lib(void) > { >

Re: [Openvpn-devel] [PATCH v4 6/7] options: enable IPv4 redirection logic only if really required

2020-06-07 Thread Gert Doering
Hi, On Sat, May 30, 2020 at 02:05:59AM +0200, Antonio Quartulli wrote: > From: Antonio Quartulli > > If no IPv4 redirection flag is set, do not enable the IPv4 > redirection logic at all so that it won't bother adding any > useless IPv4 route. > > Trac: #208 > Signed-off-by: Antonio Quartulli

Re: [Openvpn-devel] [PATCH v6 2/3] crypto_openssl: add initialization to pick up local configuration

2020-06-07 Thread James Bottomley
On Sun, 2020-06-07 at 13:11 +0200, Gert Doering wrote: > Hi, > > > diff --git a/src/openvpn/crypto_openssl.c > > b/src/openvpn/crypto_openssl.c > > index 4ac77fde..fd57edd2 100644 > > --- a/src/openvpn/crypto_openssl.c > > +++ b/src/openvpn/crypto_openssl.c > > @@ -149,6 +149,11 @@ crypto_init_lib