Re: [Openvpn-devel] [BUG] test_ncp.c failing

2020-05-29 Thread Steffan Karger
On 29-05-2020 01:46, James Bottomley wrote: > The problem seems to be openssl uses a mixed case name for the cipher > and EVP_CIPHER_name() is case sensitive. Applying the patch below > fixes this for openssl and gets make check to pass all tests, but I > rather wonder why this isn't part of ciphe

Re: [Openvpn-devel] [PATCH] Add .git-blame-ignore-revs with reformat commits

2020-05-29 Thread David Sommerseth
On 29/05/2020 01:54, Arne Schwabe wrote: > This allows git blame to ignore reformatting changes and instead > shows the previous commit that changed the line. > > To avoid manually building the list of commits this commit > adds a file with a list of reformatting commits. I might have > missed a f

Re: [Openvpn-devel] [PATCH] Add .git-blame-ignore-revs with reformat commits

2020-05-29 Thread Arne Schwabe
Am 29.05.20 um 15:51 schrieb David Sommerseth: > On 29/05/2020 01:54, Arne Schwabe wrote: >> This allows git blame to ignore reformatting changes and instead >> shows the previous commit that changed the line. >> >> To avoid manually building the list of commits this commit >> adds a file with a li

Re: [Openvpn-devel] [PATCH] Add .git-blame-ignore-revs with reformat commits

2020-05-29 Thread Antonio Quartulli
Hi, On 29/05/2020 16:21, Arne Schwabe wrote: > Am 29.05.20 um 15:51 schrieb David Sommerseth: >> On 29/05/2020 01:54, Arne Schwabe wrote: >>> +# Merge 'reformatting' branch into master >>> +1f004b2f06e987d73e48f7fd7b96b0b248274f58 >> >> Are you sure this "merge" commit shouldn't be commit 81d882d5

[Openvpn-devel] [PATCH v4 1/7] pool: prevent IPv6 pools to be larger than 2^16 addresses

2020-05-29 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- src/openvpn/pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/pool.c b/src/openvpn/pool.c index 5d503a33..6dd72bb9 100644 --- a/src/openvpn/pool.c +++ b/src/openvpn/pool.c @@ -183,7 +183,7 @@ ifconfig_pool_init(enum pool_ty

[Openvpn-devel] [PATCH v4 5/7] route: warn on IPv4 routes installation when no IPv4 is configured

2020-05-29 Thread Antonio Quartulli
From: Antonio Quartulli Same as already happens for IPv6, it is useful for the user to throw a warning when an IPv4 route is about to be installed and the tun interface has no IPv4 configured. The twin message for IPv4 is adapted to have the same format. The warning is not fatal, becuase the ro

[Openvpn-devel] [PATCH v4 0/7] Allow IPv6-only tunnels

2020-05-29 Thread Antonio Quartulli
This patchset allows servers to work with a tunnel configured with IPv6 only (client code has already been merged). This new v4 is the result of some more reviews, including an hardcore reviewing session that me and Gert had yesterday afternoon. We found some interesting bugs and agreed on some p

[Openvpn-devel] [PATCH v4 7/7] ipv6-pool: get rid of size constraint

2020-05-29 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- src/openvpn/helper.c | 7 +++ src/openvpn/options.c | 13 + src/openvpn/pool.c| 12 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/src/openvpn/helper.c b/src/openvpn/helper.c index 277e6972..2174b580 100644 -

[Openvpn-devel] [PATCH v4 3/7] allow usage of --server-ipv6 even when no --server is specified

2020-05-29 Thread Antonio Quartulli
From: Antonio Quartulli Until now OpenVPN has not allowed to specify --server-ipv6 if no --server was also set. This constraint comes from the fact that most of the IPv6 logic (i.e. ifconfig-pool handling) relied on IPv4 components to be activated and configured as well. Now that the IPv6 code p

[Openvpn-devel] [PATCH v4 6/7] options: enable IPv4 redirection logic only if really required

2020-05-29 Thread Antonio Quartulli
From: Antonio Quartulli If no IPv4 redirection flag is set, do not enable the IPv4 redirection logic at all so that it won't bother adding any useless IPv4 route. Trac: #208 Signed-off-by: Antonio Quartulli --- Changes from v4: - move error message modification to previous patch Changes from

[Openvpn-devel] [PATCH v4 4/7] pool: add support for ifconfig-pool-persist with IPv6 only

2020-05-29 Thread Antonio Quartulli
From: Antonio Quartulli Without altering the pool logic, this patch enables using a persistent IP pool also when the server is configured with IPv6 only. Trac: #208 Signed-off-by: Antonio Quartulli --- Changes from v3: - patchset rebased on top of pre-ipv6-only patchset src/openvpn/options.

[Openvpn-devel] [PATCH v4 2/7] pool: allow to configure an IPv6-only ifconfig-pool

2020-05-29 Thread Antonio Quartulli
From: Antonio Quartulli With this change a server is allowed to allocate an IPv6-only pool. This is required to make it capable of managing an IPv6-only tunnel. Trac: #208 Signed-off-by: Antonio Quartulli --- Changes from v3: - properly compute pool size taking into account the actual base add