[Openvpn-devel] [PATCH] Switch assertion failure to returning false

2020-05-20 Thread Jeremy Evans
This assertion failure can be hit in production, which causes the openvpn server process to stop and all clients to be disconnected. Bug #1270 has been filed for this issue on Trac by another user who has experienced the issue, and this patch attempts to address it. Tracing callers, it appears tha

Re: [Openvpn-devel] [PATCH] Switch assertion failure to returning false

2020-05-20 Thread Gert Doering
Hi, On Wed, May 20, 2020 at 11:34:04AM -0700, Jeremy Evans wrote: > To give some background, we hit this assertion failure, with the > following log output: This should not happen, asserting out in "normal server use" is bad. (Neither should it ever reach that point without ks->authenticated b

Re: [Openvpn-devel] [PATCH] Switch assertion failure to returning false

2020-05-20 Thread Jeremy Evans
On 05/20 09:33, Gert Doering wrote: > Hi, > > On Wed, May 20, 2020 at 11:34:04AM -0700, Jeremy Evans wrote: > > To give some background, we hit this assertion failure, with the > > following log output: > > This should not happen, asserting out in "normal server use" is bad. > > (Neither shoul