Re: [Openvpn-devel] [PATCH v2 3/5] Implement sending response to challenge via CR_RESPONSE

2020-03-28 Thread David Sommerseth
On 09/11/2019 16:13, Arne Schwabe wrote: > When a client announces its support to support text based > challenge/response via IV_SOO=cr_text,the client needs to also Typo. IV_SOO -> IV_SSO > be able to reply to that response. > > This adds the "cr-response" management function to be able to > d

Re: [Openvpn-devel] [PATCH] Reformat all source files

2020-03-28 Thread David Sommerseth
On 16/11/2019 11:28, Arne Schwabe wrote: > Over time some patches slipped in that were not 100% complient to uncrustify > This rerun fixes those issues > > This run used Uncrustify-0.69.0_f > --- > src/openvpn/buffer.c | 2 +- > src/openvpn/crypto.h | 2 +- > src/openv

Re: [Openvpn-devel] [PATCH v2 1/5] Implement parsing and sending INFO and INFO_PRE control messages

2020-03-28 Thread David Sommerseth
On 09/11/2019 16:13, Arne Schwabe wrote: > OpenVPN 3 implements these messages to send information during the > authentication to the UI, implement these message also in OpenVPN 2.x > > Signed-off-by: Arne Schwabe > --- > src/openvpn/forward.c | 8 > src/openvpn/push.c| 33

Re: [Openvpn-devel] [PATCH v2 4/5] Implement sending SSO challenge to clients

2020-03-28 Thread David Sommerseth
On 09/11/2019 16:13, Arne Schwabe wrote: > This implements sending AUTH_PENDING and INFO_PRE messages to clients > that indicate that the clients should be continue authentication with > a second factor. This can currently be out of band (openurl) or a normal > challenge/response 2FA like TOTP (CR_

Re: [Openvpn-devel] [PATCH v2 2/5] Implement support for signalling IV_SSO to server

2020-03-28 Thread David Sommerseth
Sorry, I'm loosing grip of my mailing-list-fu ... Managed to reply only to Arne. On 27/03/2020 21:59, David Sommerseth wrote: > On 09/11/2019 16:13, Arne Schwabe wrote: >> Signed-off-by: Arne Schwabe >> --- >> src/openvpn/ssl.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> di

Re: [Openvpn-devel] [PATCH] Reformat all source files

2020-03-28 Thread Gert Doering
Hi, On Fri, Mar 27, 2020 at 04:24:00PM +0100, David Sommerseth wrote: > On 16/11/2019 11:28, Arne Schwabe wrote: > > Over time some patches slipped in that were not 100% complient to uncrustify > > This rerun fixes those issues [..] > Only done quick code review and RHEL-7 build. Changes looks re