Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-26 Thread Arne Schwabe
Am 25.03.20 um 19:35 schrieb Michael Kress: > Hello Arne, > > Am Wed, 25 Mar 2020 12:50:34 +0100 > schrieb Arne Schwabe : >>> 1) Do you run automated tests of the OpenVPN code on any build >>> server? >>> >>> 2) If that is the case, is there any test with a version, where >>>-DVERIFY_ALIGNME

[Openvpn-devel] [PATCH] [PATCH V3] - changed remote lenght and refactored get_env

2020-03-26 Thread Paolo Cerrito
1) I put remote lenght to 51, as it have to hold ipv6/ipv4 ip address plus string terminator. 2) As asked, i refactor the call to get_env, so now first of all there is a one call to get_env to get the ipv6 address, if is not set, and only in this case, we recall get_env for ipv4. --- .giti

[Openvpn-devel] [PATCH] PATCH V3 - changed remote lenght and refactored get_env

2020-03-26 Thread Paolo Cerrito
--- .gitignore | 1 + src/plugins/auth-pam/auth-pam.c | 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 0d68ec4b..3977882f 100644 --- a/.gitignore +++ b/.gitignore @@ -72,3 +72,4 @@ nbproject test-driver compile stamp

[Openvpn-devel] [PATCH 3/3] [auth-token] Document reneweal mechanic of auth-token in manual

2020-03-26 Thread Arne Schwabe
Our man page was missing the information that the life time of the auth-token also depends on the reneg-sec --- doc/openvpn.8 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 864f94e8..f890e7a2 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@ -3741,6 +

[Openvpn-devel] [PATCH 1/3] [Auth-token] Fix session id and initial timestamp not begin preserved

2020-03-26 Thread Arne Schwabe
In the initial state of checking whether an auth-token has been validated, the check check if multi->auth_token is already set and only then sets the value. This defeats the purpose and lead to always a new auth-token with new session id and lifetime being generated when the server restarts or the

[Openvpn-devel] [PATCH 2/3] [Auth-token] Fix session id in env missing first byte

2020-03-26 Thread Arne Schwabe
sizeof for a constant string return the size including the null byte. For copying the session id this meant that we do not copy the first byte. This made the session id reported to the external authenticator one byte shorter than it was indented to be. --- src/openvpn/auth_token.c | 2 +- 1 file c

Re: [Openvpn-devel] [PATCH 3/3] [auth-token] Document reneweal mechanic of auth-token in manual

2020-03-26 Thread Nathan Stratton Treadway
On Thu, Mar 26, 2020 at 18:23:32 +0100, Arne Schwabe wrote: > diff --git a/doc/openvpn.8 b/doc/openvpn.8 > index 864f94e8..f890e7a2 100644 > --- a/doc/openvpn.8 > +++ b/doc/openvpn.8 > @@ -3741,6 +3741,12 @@ argument defines how long the generated token is > valid. The > lifetime is defined in s

[Openvpn-devel] Summary of the community meeting (26th March 2020)

2020-03-26 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Thu 26th March 2020 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this meeting were here: Your local meet

Re: [Openvpn-devel] Summary of the community meeting (26th March 2020)

2020-03-26 Thread Selva Nair
Hi, Quoting from the 26th March meeting summary > Noted that the combination of a username-only --auth-user-pass and > --management-query-passwords does not work. Dazo will take a stab at > fixing the actual problem. There is already a > GET_USER_PASS_PASSWORD_ONLY flag which just needs to be pro