[Openvpn-devel] [PATCH] travis: bump clang version

2019-11-29 Thread Lev Stipakov
From: Lev Stipakov This should fix "suggest braces around initialization of subobject" warning. Signed-off-by: Lev Stipakov --- .travis.yml | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 61be17cd..40296d87 100644 --- a/.tr

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread David Sommerseth
On 28/11/2019 20:43, Gert Doering wrote: > hi, > > On Thu, Nov 28, 2019 at 11:56:34AM -0500, Selva Nair wrote: >> I think the correct fix here is to remove -Werror from travis build. >> I have tried and failed to lobby for this earlier, but one more try >> can't hurt, I suppose :) > > Can we rest

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread Lev Stipakov
I upgraded clang to 9.0 and warning disappeared. https://travis-ci.org/lstipakov/openvpn/builds/618527918 Patch is on the list. to 28. marrask. 2019 klo 21.44 Gert Doering (g...@greenie.muc.de) kirjoitti: > hi, > > On Thu, Nov 28, 2019 at 11:56:34AM -0500, Selva Nair wrote: > > I think the corr

[Openvpn-devel] [PATCH applied] Re: travis: bump clang version

2019-11-29 Thread Gert Doering
Acked-by: Gert Doering This looks reasonable - we want to see warnings-as-errors with recent compilers. Older compilers may warn all they want, but we can not consider it an *error* or spend time on fixing them (in ugly ways). Your patch has been applied to the master branch. commit 4a2c8dab5

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread Gert Doering
Hi, On Fri, Nov 29, 2019 at 11:47:02AM +0100, David Sommerseth wrote: > With GCC-4.3.8, I see this warning: This is about as old as you :-) - do we care about suppressing warnings in old gcc versions that might suppress a *relevant* warning when compiling with a current gcc version? gert -- "If

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread David Sommerseth
On 29/11/2019 11:52, Gert Doering wrote: > Hi, > > On Fri, Nov 29, 2019 at 11:47:02AM +0100, David Sommerseth wrote: >> With GCC-4.3.8, I see this warning: > > This is about as old as you :-) - do we care about suppressing warnings > in old gcc versions that might suppress a *relevant* warning wh

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread Gert Doering
Hi, On Fri, Nov 29, 2019 at 12:25:13PM +0100, David Sommerseth wrote: > On 29/11/2019 11:52, Gert Doering wrote: > > On Fri, Nov 29, 2019 at 11:47:02AM +0100, David Sommerseth wrote: > >> With GCC-4.3.8, I see this warning: > > > > This is about as old as you :-) - do we care about suppressing wa

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread David Sommerseth
On 29/11/2019 12:37, Gert Doering wrote: > Hi, > > On Fri, Nov 29, 2019 at 12:25:13PM +0100, David Sommerseth wrote: >> On 29/11/2019 11:52, Gert Doering wrote: >>> On Fri, Nov 29, 2019 at 11:47:02AM +0100, David Sommerseth wrote: With GCC-4.3.8, I see this warning: >>> >>> This is about as o

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread Gert Doering
Hi, On Fri, Nov 29, 2019 at 01:22:26PM +0100, David Sommerseth wrote: > > I'm just not going to care very much about the warnings it might throw > > (and I might object to any patches that are "just for the benefit of > > suppressing warnings from gcc-4"). > > Fair enough. But that will actually