[Openvpn-devel] Community meetings in August 2019

Hi, Our community meetings will alternate between Wed 11:30 CEST and Thu 20:00 CEST. Next meetings have been scheduled to - Wed 7th August 11:30 CEST - Thu 15th August 20:00 CEST - Wed 21st August 11:30 CEST - Thu 29th August 20:00 CEST The place is #openvpn-meeting IRC channel at Freenode. Mee

[Openvpn-devel] [PATCH 0/6] sitnl follow-up

From: Antonio Quartulli Hi all, this small patchset aims at tackling most of the concerns raised by Gert while merging the sitnl introduction patchset. All patches are fairly small, but they are a bit intertwined (they change nearby lines), therefore it would be better to merge them in the pro

[Openvpn-devel] [PATCH 1/6] sitnl: harden strncpy() by forcing arguments to have the same length

From: Antonio Quartulli At the moment a strcpy() (without length check!) is performed between a string long IFNAMSIZ bytes and one of 16 bytes. This is ok right now because IFNAMSIZ is defined as 16, however this bit is not under our control and may change in he future without us being warned. F

[Openvpn-devel] [PATCH 3/6] networking: extend API for better memory management

From: Antonio Quartulli Networking backend implementations may need to allocate dynamic resources that require an explicit free/release. Since these cleanup are perfomed not very often, and only at specific times, it makes sense to have the upper layer signal when it's the right time to do so, by

[Openvpn-devel] [PATCH 6/6] route.c: simplify ifdef logic

With the introduction of the new networking API layer on linux, some ifdefs can be pruned or simplified. While at it move some variable to improve readability. Signed-off-by: Antonio Quartulli --- src/openvpn/route.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) d

[Openvpn-devel] [PATCH 2/6] networking/best_gw: remove useless prefixlen parameter

From: Antonio Quartulli The prefixlen parameter is not used at all while retrieving a route therefore it can safely be removed. Signed-off-by: Antonio Quartulli --- src/openvpn/networking.h | 7 ++- src/openvpn/networking_iproute2.c | 4 ++-- src/openvpn/networking_sitnl.c|

[Openvpn-devel] [PATCH 4/6] tun.c: undo_ifconfig_ipv4/6 remove useless gc argument

From: Antonio Quartulli With the new networking APIs, each implementation handles garbage collection internally and therefore does not require a gc object to be provided by the outer layer. However, there are a few cases where a garbage collector is still required. In close_tun() move the declar

[Openvpn-devel] [PATCH 5/6] networking_sitnl.c: uncrustify file

Give this file a run under uncrustify to fix a few style glitches here and there. Signed-off-by: Antonio Quartulli --- src/openvpn/networking_sitnl.c | 62 +++--- 1 file changed, 43 insertions(+), 19 deletions(-) diff --git a/src/openvpn/networking_sitnl.c b/src/open

Re: [Openvpn-devel] [PATCH 1/6] sitnl: harden strncpy() by forcing arguments to have the same length

>For this reason, force both strings to use IFNAMSIZ as size and, since >this constant may not exist on every platform, ensure it is always >defined. A problem with this patch misght be that strncpy() does NOT NUL terminates the copied string. (It writes EXACTLY IFNAMSIZ bytes but only when th

Re: [Openvpn-devel] [PATCH 1/6] sitnl: harden strncpy() by forcing arguments to have the same length

Hi and thanks for your review, On 05/08/2019 11:33, casper@oracle.com wrote: > > >> For this reason, force both strings to use IFNAMSIZ as size and, since >> this constant may not exist on every platform, ensure it is always >> defined. > > A problem with this patch misght be that strncpy()

Re: [Openvpn-devel] [PATCH 0/6] sitnl follow-up

FYI, this patchset has undergone buildbot, travis-ci and gitlab-ci testing and nothing out of the ordinary came out. Regards, On 05/08/2019 11:25, Antonio Quartulli wrote: > From: Antonio Quartulli > > Hi all, > > this small patchset aims at tackling most of the concerns raised by Gert > whi