[Openvpn-devel] [PATCH v2] Remove cmocka submodule, rely on system-wide installation instead.

2019-06-23 Thread Gert Doering
We used to ship git submodule instructions to build a local copy of cmocka in vendor/cmocka/ and use that (if cmake is installed) to build unit tests. With the network test driver this turns out to be a LD_LIBRARY_PATH vs. SUDO complication which is really outweighing the benefit of a local build

[Openvpn-devel] [PATCH applied] Re: configure.ac: add lzo CFLAGS/LIBS to the test flags

2019-06-23 Thread Gert Doering
Your patch has been applied to the master branch. (Unfortunately, this sabotages my just-sent v2 of the cmocka cleanup patch, so I'll send a v3 right away) commit 7473f326366fbceb4094d43d3c21fa6d5d0782e6 Author: Steffan Karger Date: Sun Jun 2 12:18:31 2019 +0200 configure.ac: add lzo CFLA

[Openvpn-devel] [PATCH v3] Remove cmocka submodule, rely on system-wide installation instead.

2019-06-23 Thread Gert Doering
We used to ship git submodule instructions to build a local copy of cmocka in vendor/cmocka/ and use that (if cmake is installed) to build unit tests. With the network test driver this turns out to be a LD_LIBRARY_PATH vs. SUDO complication which is really outweighing the benefit of a local build

Re: [Openvpn-devel] [PATCH applied] Re: configure.ac: add lzo CFLAGS/LIBS to the test flags

2019-06-23 Thread Gert Doering
Hi, On Sun, Jun 23, 2019 at 08:22:32PM +0200, Gert Doering wrote: > commit 7473f326366fbceb4094d43d3c21fa6d5d0782e6 > Author: Steffan Karger > Date: Sun Jun 2 12:18:31 2019 +0200 > > configure.ac: add lzo CFLAGS/LIBS to the test flags > > Signed-off-by: Steffan Karger > Acked-b

[Openvpn-devel] [bui...@travis-ci.org: Still Failing: OpenVPN/openvpn#874 (master - 7473f32)]

2019-06-23 Thread Gert Doering
Hi, travis CI builds for MacOS fail (and have failed for quite some time, it seems) because LZO is not installed as pre-requisite - the configure run in the log below ends in line 632 with configure: error: lzo enabled but missing ... but it *should* be built by ".travis/build-deps.sh" - so it

[Openvpn-devel] [PATCH applied] Re: man: correct the description of --capath and --crl-verify regarding CRLs

2019-06-23 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. Fixed one "hash>." typo on the fly. commit b3cfc43da3583ae8aa761beb29f016311b2ba64f (master) commit 3f72b838fd505dbd898cced364a655eef08a8c27 (release/2.4) Author: Michal Soltys Date: Tue Apr 9 16:34:38 2019 +0200 man: corre

Re: [Openvpn-devel] [bui...@travis-ci.org: Still Failing: OpenVPN/openvpn#874 (master - 7473f32)]

2019-06-23 Thread Илья Шипицин
Thank you for the investigation, Gert. I'll have a look soon On Sun, Jun 23, 2019, 11:55 PM Gert Doering wrote: > Hi, > > travis CI builds for MacOS fail (and have failed for quite some time, > it seems) because LZO is not installed as pre-requisite - the configure > run in the log below ends in