[Openvpn-devel] [PATCH 0/4] struct argv overhaul - round 2+x

2018-10-19 Thread David Sommerseth
Hi, Since the hackathon a couple of weeks ago, I've picked up the work from Heiko Hund which does a big overhaul on the struct argv patches [0]. This patchset is rebased on the latest master and with my review comments embedded into Heikos patch. This was only relevant for the big 're-implement

[Openvpn-devel] [PATCH 2/4] argv: do fewer memory re-allocations

2018-10-19 Thread David Sommerseth
From: Heiko Hund Prevent the re-allocations of memory when the internal argv grows beyond 2 and 4 arguments by initially allocating argv to hold up to 7 (+ trailing NULL) pointers. While at it rename argv_reset to argv_free to actually express what's going on. Redo the argv_reset functionality s

[Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2018-10-19 Thread David Sommerseth
From: Heiko Hund The previous implementation had the problem that it was not fully compatible with printf() and could only detect % format directives following a space character (0x20). It modifies the format string and inserts marks to separate groups before passing it to the regular printf in

[Openvpn-devel] [PATCH 4/4] Documented all the argv related code with minor refactoring

2018-10-19 Thread David Sommerseth
Added doxygen comments for all the functions in argv.c. There are some slight refactoring, renaming a few variables to make their use case more obvious and ensure lines do not break our 80-chars per line coding style limit. Signed-off-by: David Sommerseth --- src/openvpn/argv.c | 246 ++

[Openvpn-devel] [PATCH 3/4] Add gc_arena to struct argv to save allocations

2018-10-19 Thread David Sommerseth
From: Heiko Hund With the private gc_arena we do not have to allocate the strings found during parsing again, since we know the arena they are allocated in is valid as long as the argv vector is. Signed-off-by: Heiko Hund --- src/openvpn/argv.c | 44 --