[Openvpn-devel] switching openvpn-gui to github releases (instead if http://build.openvpn.net/...)

2018-10-01 Thread Илья Шипицин
Hello, I was absent for few days :) Glad to see you again. I want to discuss whether we can choose github releases as primary source here: https://github.com/OpenVPN/openvpn-build/blob/master/generic/build.vars#L15 Cheers, Ilya Shipitsin ___ Openvpn-d

Re: [Openvpn-devel] switching openvpn-gui to github releases (instead if http://build.openvpn.net/...)

2018-10-01 Thread Илья Шипицин
sorry, I meant "OPENVPN_GUI_URL" variable of course. пн, 1 окт. 2018 г. в 14:49, Илья Шипицин : > Hello, > > I was absent for few days :) Glad to see you again. > I want to discuss whether we can choose github releases as primary source > here: > > https://github.com/OpenVPN/openvpn-build/blob/ma

Re: [Openvpn-devel] switching openvpn-gui to github releases (instead if http://build.openvpn.net/...)

2018-10-01 Thread David Sommerseth
On 01/10/18 11:49, Илья Шипицин wrote: > Hello, > > I was absent for few days :) Glad to see you again. > I want to discuss whether we can choose github releases as primary source > here: > > https://github.com/OpenVPN/openvpn-build/blob/master/generic/build.vars#L15 No. We do not want to chan

Re: [Openvpn-devel] [PATCH] Enable dhcp on tap adapter using interactive service

2018-10-01 Thread Lev Stipakov
Hi, Thanks, I tested on Windows 10 with Visual Studio build and works as expected. A few nitpicks: +if (!WriteFile(pipe, &dhcp, sizeof(dhcp), &len, NULL) > +|| !ReadFile(pipe, &ack, sizeof(ack), &len, NULL)) > +{ > +msg(M_WARN, "TUN: could not talk to service: %s [%lu]",

Re: [Openvpn-devel] [PATCH] Enable dhcp on tap adapter using interactive service

2018-10-01 Thread Selva Nair
Hi, Thanks for the review and comments. A quick reply below, will send a v2 later. On Mon, Oct 1, 2018 at 7:11 AM Lev Stipakov wrote: > Hi, > > Thanks, I tested on Windows 10 with Visual Studio build and works as > expected. > > A few nitpicks: > > +if (!WriteFile(pipe, &dhcp, sizeof(dhcp),