[Openvpn-devel] [PATCH] Remove unused void_ptr_hash_function and void_ptr_compare_function

Both functions are never used, so let's get rid of them. Signed-off-by: Steffan Karger --- src/openvpn/list.c | 12 src/openvpn/list.h | 4 2 files changed, 16 deletions(-) diff --git a/src/openvpn/list.c b/src/openvpn/list.c index 09e393a..6023ea6 100644 --- a/src/openvpn/li

[Openvpn-devel] [PATCH] Refactor NCP-negotiable options handling

From: Lev Stipakov This patch decouples setting/unsetting NCP options from the state of TLS context. At startup (and then per sighup) we load config (pre-NCP) values to c1, which persists over sigusr1. When tearing tunnel down we restore (possibly modified) c->options back to c1 (original) values

[Openvpn-devel] [PATCH applied] Re: Remove unused void_ptr_hash_function and void_ptr_compare_function

Acked-by: Gert Doering Because it's dead code. Looking again, it actually seems correct after all :-) (void_ptr_hash_function() is passed in a pointer *value*, which is then stored locally, and the address of this local store is handed to hash_func() - so it compares "memory addresses". Misread

Re: [Openvpn-devel] [PATCH] Refactor NCP-negotiable options handling

On 19/09/18 18:37, Lev Stipakov wrote: > From: Lev Stipakov > > This patch decouples setting/unsetting NCP options > from the state of TLS context. At startup (and then > per sighup) we load config (pre-NCP) values to c1, > which persists over sigusr1. When tearing tunnel down > we restore (possi