Re: [Openvpn-devel] [PATCH v2 3/9] Add crypto_pem_{encode, decode}()

2018-07-22 Thread Steffan Karger
Hi, On 20-07-18 13:20, Antonio Quartulli wrote: > Hi, > > On 05/07/18 01:53, Steffan Karger wrote: > [CUT] > >> +bool >> +crypto_pem_decode(const char *name, struct buffer *dst, >> + const struct buffer *src) >> +{ >> +bool ret = false; >> +BIO *bio; >> + >> +if (!(b

[Openvpn-devel] [PATCH v3 2/9] Add crypto_pem_{encode,decode}()

2018-07-22 Thread Steffan Karger
From: Steffan Karger Needed for tls-crypt-v2, but isolated enough to be reviewed as a separate patch. The encode API allocates memory, because it fits our typical gc-oriented code pattern and the caller does not have to do multiple calls or calculations to determine the required destination buff

Re: [Openvpn-devel] [PATCH v2 3/9] Add crypto_pem_{encode, decode}()

2018-07-22 Thread Antonio Quartulli
Hi, On 22/07/18 17:53, Steffan Karger wrote: >>> +uint8_t *dst_data = buf_write_alloc(dst, data_read_len); >>> +if (!dst_data) >>> +{ >>> +dmsg(D_CRYPT_ERRORS, "%s: dst too small (%i, needs %li)", __func__, >>> + BCAP(dst), data_read_len); >>> +goto cleanup;

Re: [Openvpn-devel] [PATCH v3 2/9] Add crypto_pem_{encode, decode}()

2018-07-22 Thread Antonio Quartulli
Hi, On 22/07/18 18:06, Steffan Karger wrote: > From: Steffan Karger > > Needed for tls-crypt-v2, but isolated enough to be reviewed as a separate > patch. > > The encode API allocates memory, because it fits our typical gc-oriented > code pattern and the caller does not have to do multiple call

[Openvpn-devel] [PATCH applied] Re: Add crypto_pem_{encode, decode}()

2018-07-22 Thread Gert Doering
Your patch has been applied to the master branch. commit a5d35a01dcf73e6a93f59d687adb6e5be38c7750 Author: Steffan Karger Date: Sun Jul 22 12:06:45 2018 +0200 Add crypto_pem_{encode,decode}() Signed-off-by: Steffan Karger Acked-by: Antonio Quartulli Message-Id: <2018072210

[Openvpn-devel] [PATCH] Resolves small IV_GUI_VER typo in the documentation

2018-07-22 Thread James Bekkema
According to the source code, the environment variable for the GUI version should be IV_GUI_VER, rather than IV_UI_VER. This patch simply fixes this small typo in the docs. Signed-off-by: James Bekkema Thanks, James -- James Bekkema SparkLabs Developer https://www.sparklabs.com https://twitte

[Openvpn-devel] [PATCH] Restore functionality of route-gateway's dhcp parameter

2018-07-22 Thread James Bekkema
This patch restores functionality of route-gateway's dhcp parameter, and expands it to support routes using vpn_gateway. OpenVPN supports using a “dhcp” parameter for the "route-gateway” option, which involves intercepting the DHCP reply packet and extracting the gateway to use. However, the cu

[Openvpn-devel] [PATCH] Adds support for setting the default IPv6 gateway for routes using the route-ipv6-gateway option

2018-07-22 Thread James Bekkema
This patch adds support for setting the default IPv6 gateway for routes using the "route-ipv6-gateway” option. Currently if users try to use the "redirect-gateway ipv6” option, or a IPv6 route without a gateway, without using "ifconfig-ipv6" they’ll receive the message "OpenVPN ROUTE6: OpenVPN