Hi,
On 21-01-18 06:37, Selva Nair wrote:
>
> On Sat, Jan 20, 2018 at 11:41 AM, Steffan Karger wrote:
>>
>> This by default enables the compiler warnings any could previously
>> enable using the --enable-strict configure option. I think it is
>> okay to do so now, because we've taken care of man
Hi,
On 20-01-18 05:52, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> - If an NCRYPT handle for the private key can be obtained, use
> NCryptSignHash from the Cryptography NG API to sign the hash.
>
> This should work for all keys in the Windows certifiate stores
> but may fail for ke
Hi,
Sorry for taking so long to review. At least some early review comments:
On 04-12-17 22:16, j...@carroll.com wrote:
> From: Jim Carroll
>
> Signed-off-by: Jim Carroll
> ---
> INSTALL | 78
>
> Makefile.am
Hi Steffan,
Thank you for the review and the ack.
On Sun, Jan 21, 2018 at 5:58 AM, Steffan Karger
wrote:
> Hi,
>
> On 20-01-18 05:52, selva.n...@gmail.com wrote:
>> From: Selva Nair
>>
>> - If an NCRYPT handle for the private key can be obtained, use
>> NCryptSignHash from the Cryptography NG
Hi,
All good but for some minor glitches:
extra whitespace:
Applying: Treat dhcp-option DNS6 and DNS identical
/home/selva/openvpn/.git/rebase-apply/patch:83: trailing whitespace.
}
/home/selva/openvpn/.git/rebase-apply/patch:84: trailing whitespace.
else
warning: 2 lines
> > +if test "${enable_fips_mode}" = "yes"; then
> > +AC_CHECK_FUNCS(
> > +[ \
> > +FIPS_mode \
> > +FIPS_mode_set \
> > +SSLeay_version
> > +],
> > +[],
> > +[AC_MSG_ERROR([Incorrect version
Hi,
I'm on a reviewing spree (doing my penance), so here goes..
Thanks for the patch
On Tue, Jan 9, 2018 at 2:16 AM, Eyal Birger wrote:
> Address prefix length defaults to /64 on Windows. This change allows using
> Windows clients in setups that use a different prefix length.
>
> Note: the abil
Hi,
I haven't tested this, but looks like a useful thing to do. The code
looks good too. Some minor comments below:
On Tue, Dec 5, 2017 at 7:19 AM, Jiří Engelthaler wrote:
> When DHCP media sense configuration is disabled, network applications
> including DHCP client will not receive information
