[Openvpn-devel] [PATCH 2/2] Make most registry values optional

2017-11-18 Thread selva . nair
From: Selva Nair Not all installations need registry values such as log_dir and config_dir especially if automatic service is not in use. This patch provides reasonable defaults for registry values. - Read the default value of HKLM\Software\PACKAGE_NAME to get the install path and construct de

[Openvpn-devel] [PATCH 1/2] Ensure strings read from registry are null-terminated

2017-11-18 Thread selva . nair
From: Selva Nair - Strings stored in registry are not guaranteed to be null-terminated. So, use RegGetValue() instead of RegQueryValueEx() as the former adds null termination to the returned string if missing. (Needs Windows Vista+) - While at it also add a default value parameter to GetRe

Re: [Openvpn-devel] input validation for username, password etc.

2017-11-18 Thread Илья Шипицин
2017-11-18 8:25 GMT+05:00 Selva : > Hi, > > I want to add some form of validation for user input in the GUI so that > the user can be alerted when username, password etc. contains characters > that may not work. > > So far the only characters that appear to be problematic are new line > ('\n') and

Re: [Openvpn-devel] input validation for username, password etc.

2017-11-18 Thread Selva
On Sun, Nov 19, 2017 at 12:06 AM, Илья Шипицин wrote: > > > 2017-11-18 8:25 GMT+05:00 Selva : > >> Hi, >> >> I want to add some form of validation for user input in the GUI so that >> the user can be alerted when username, password etc. contains characters >> that may not work. >> >> So far the o

Re: [Openvpn-devel] input validation for username, password etc.

2017-11-18 Thread Илья Шипицин
2017-11-19 10:43 GMT+05:00 Selva : > > > On Sun, Nov 19, 2017 at 12:06 AM, Илья Шипицин > wrote: > >> >> >> 2017-11-18 8:25 GMT+05:00 Selva : >> >>> Hi, >>> >>> I want to add some form of validation for user input in the GUI so that >>> the user can be alerted when username, password etc. contain