Re: [Openvpn-devel] [PATCH 01/13] snwprintf() => _snwprintf()

Hi Simon, From a technical point of view, it looks like a fine patch. But it is hard for me (as a non-Windows dev) to understand *why* this is needed. It would be good to explain the rationale for a change so others can understand it as quickly as possible. I won't dive deep into how to write g

Re: [Openvpn-devel] How to manage code under the contrib/ directory?

Il 05/10/2017 17:04, Steffan Karger ha scritto: > Hi, > > On 05-10-17 12:35, Samuli Seppänen wrote: >> In yesterday's community meeting we talked a bit about how to best >> manage code under contrib/ directory: >> >> >> >> We agreed that cod

Re: [Openvpn-devel] [PATCH 01/13] snwprintf() => _snwprintf()

Hi, > From a technical point of view, it looks like a fine patch. But it is hard > for me > (as a non-Windows dev) to understand *why* this is needed. > It would be good to explain the rationale for a change so others can > understand it as quickly as possible. snwprintf() is not defined in Win

[Openvpn-devel] Topics for the community meeting (Wed, 11th Oct 2017)

Hi, We're going to have an IRC meeting today starting at 19:00 CEST (17:00 UTC) on #openvpn-meeting irc.freenode.net. You do not have to be logged in to Freenode to join the channel. Current topic list along with basic information is here:

Re: [Openvpn-devel] [PATCH 01/13] snwprintf() => _snwprintf()

On Wed, Oct 11, 2017 at 6:06 AM, Simon Rozman wrote: > Hi, > > > From a technical point of view, it looks like a fine patch. But it is > hard > > for me > > (as a non-Windows dev) to understand *why* this is needed. > > It would be good to explain the rationale for a change so others can > > und

Re: [Openvpn-devel] [PATCH 05/13] Function prototypes are declared as "typedef ( *type_name)()" in MSVC.

Hi, Thanks for these patches. On Tue, Oct 10, 2017 at 7:11 PM, wrote: > From: Simon Rozman > > Note: NETIOAPI_API is defined as: > #define NETIOAPI_API NETIO_STATUS NETIOAPI_API_ > #define NETIOAPI_API_ WINAPI > > I am not sure whether interactive.c will compile using mingw with this > patch.

[Openvpn-devel] [PATCH] Document ">PASSWORD:Auth-Token" real-time message

From: Simon Rozman Authentication tokens are security enhancement eliminating client need to cache passwords, and are indispensable at two factor authentication methods, such as HOTP or TOTP. The ">PASSWORD:Auth-Token" message was not mentioned anywhere in the OpenVPN Management Interface Notes.

Re: [Openvpn-devel] [PATCH 02/13] Mixing wide and regular strings in concatenations is not allowed in MSVC.

Hi, On Tue, Oct 10, 2017 at 7:11 PM, wrote: > From: Simon Rozman > > --- > src/openvpnserv/interactive.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c > index 9d473e4..4b08086 100644 > --- a/src/op

[Openvpn-devel] [PATCH] Fix typo in "verb" command examples

From: Simon Rozman --- doc/management-notes.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/management-notes.txt b/doc/management-notes.txt index 29c3aad..0e7a7d4 100644 --- a/doc/management-notes.txt +++ b/doc/management-notes.txt @@ -420,7 +420,7 @@ info on verbosit

Re: [Openvpn-devel] [PATCH 05/13] Function prototypes are declared as "typedef ( *type_name)()" in MSVC.

Hi, I shall happily rewrite the code to remove those declarations. However, I'll need to check MSDN on a case-by-case basis to replace only API calls that are standard from Vista on. Do you still maintain 2.3 branch for Windows XP? You do know, that replacing GetProcAddr() with statically

Re: [Openvpn-devel] [PATCH 01/13] snwprintf() => _snwprintf()

Hi, I agree migration towards ISO-C's snwprintf() is better. We can do it two way: using #define, or implementing a simple wrapper function. The advantage of wrapper function is we can introduce guaranteed null-terminated output to match ISO-C experience. Best regards, Simon From: Se

Re: [Openvpn-devel] [PATCH 05/13] Function prototypes are declared as "typedef ( *type_name)()" in MSVC.

Hi, Do you still maintain 2.3 branch for Windows XP? You do know, that > replacing GetProcAddr() with statically linked Vista+ API calls would break > compatibility with Windows XP. > The interactive service is only available in 2.4 and above and was never released for XP. Those dynamic lookups

Re: [Openvpn-devel] [PATCH 01/13] snwprintf() => _snwprintf()

Hi On Wed, Oct 11, 2017 at 10:03 AM, Simon Rozman wrote: > Hi, > > > > I agree migration towards ISO-C's snwprintf() is better. > Just to be sure, ISO-C is 'swprintf' not 'snwprintf'. In spite of 'n' misisng from that name, it takes the buffer size argument and nul terminates even if output is

Re: [Openvpn-devel] [PATCH 04/13] Local functions are not supported in MSVC. Bummer.

Hi, On Tue, Oct 10, 2017 at 7:11 PM, wrote: > From: Simon Rozman > > --- > src/openvpnserv/interactive.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c > index 2019d38..7ff45b1 100644 > --- a/src

[Openvpn-devel] [PATCH applied] Re: Local functions are not supported in MSVC. Bummer.

Your patch has been applied to the master and release/2.4 branch. commit 0893b14a7f8023964760e6229badcd2cfef57de2 (master) commit 1b49bda5e10435dd42c2fe48d40893689fbdf986 (release/2.4) Author: Simon Rozman Date: Wed Oct 11 01:11:21 2017 +0200 Local functions are not supported in MSVC. Bumm

Re: [Openvpn-devel] [PATCH 05/13] Function prototypes are declared as "typedef ( *type_name)()" in MSVC.

Hi, On Wed, Oct 11, 2017 at 01:57:03PM +, Simon Rozman wrote: > Do you still maintain 2.3 branch for Windows XP? You do know, that replacing > GetProcAddr() with statically linked Vista+ API calls would break > compatibility with Windows XP. These patches won't go into 2.3 - 2.3 is in stric

[Openvpn-devel] [PATCH applied] Re: Mixing wide and regular strings in concatenations is not allowed in MSVC.

Your patch has been applied to the master and release/2.4 branch. commit d6e0917922793315b06aba395ed0666e17c5b44c (master) commit 6e9da5a55673fe01ae7b780f0c438c81773109d5 (release/2.4) Author: Simon Rozman Date: Wed Oct 11 01:11:19 2017 +0200 Mixing wide and regular strings in concatenatio

[Openvpn-devel] Summary of the community meeting (Wed, 11th Oct 2017)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wednesday 11th Oct 2017 Time: 19:00 CET (17:00 UTC) Planned meeting topics for this meeting were here: The next me

Re: [Openvpn-devel] [PATCH 03/13] RtlIpv6AddressToStringW() and RtlIpv4AddressToStringW() require mstcpip.h

Hi, On Tue, Oct 10, 2017 at 7:11 PM, wrote: > From: Simon Rozman > > --- > src/openvpnserv/interactive.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c > index 4b08086..2019d38 100644 > --- a/src/openvpnserv/interactive.c