[Openvpn-devel] [PATCH 2/2 v3] pf: clean up temporary files if plugin init fails

2017-09-29 Thread Steffan Karger
From: Steffan Karger close_instance() tries to remove the file in c2.pf.filename, but that only works if we actually set that if we fail. So, set that filename as soon as we know we've created the file. Signed-off-by: Steffan Karger --- v2: As suggested by Antionio, get rid of local 'gc' and '

Re: [Openvpn-devel] [PATCH v4 1/3] pf: restyle pf_c2c/addr_test() to make them 'struct context' agnostic

2017-09-29 Thread Steffan Karger
Hi, On 18-09-17 20:13, Antonio Quartulli wrote: > In the attempt of getting rid of any pf-inline.h file, we need > to make sure that inline functions do not trigger any circular > include dependency. > > For this reason, avoid pf_c2c/addr_test() to be 'struct context' > aware, so that pf-inline.h

[Openvpn-devel] [PATCH 0/2] Reject client if PF plugin is configured, but init fails

2017-09-29 Thread Steffan Karger
This changes the behavior for pf plugins: instead of just not initializing the firewall rules and happily continuing, this now rejects the client in the case of an (unlikely) failure to initialize the pf. Signed-off-by: Steffan Karger --- src/openvpn/pf.c | 9 + 1 file changed, 5 inserti

[Openvpn-devel] [PATCH v2] create_temp_file/gen_path: prevent memory leak if gc == NULL

2017-09-29 Thread Steffan Karger
If gc == NULL, the data allocated in the alloc_gc_buf() call in create_temp_file or the string_mod_const call in gen_path would never be free'd. These functions are currently never called that way, but let's prevent future problems. While touching create_temp_file, also remove the counter variabl

[Openvpn-devel] [PATCH 1/2 v2] Don't throw fatal errors from create_temp_file()

2017-09-29 Thread Steffan Karger
From: Steffan Karger This function is called in response to connecting clients, and can fail when I/O fails for some (possibly temporary) reason. In such cases we should not exit the process, but just reject the connecting client. This commit changes the function to actually return NULL on erro

Re: [Openvpn-devel] [PATCH applied] Fix short-option overlapping

2017-09-29 Thread David Sommerseth
From: David Sommerseth -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the wip branch commit c41c677c36a105325728a6749885060e3095e845 Author: Antonio Quartulli Date: Tue Sep 19 17:03:10 2017 +0800 Fix short-option overlapping Signed-off-by: Antonio Q

Re: [Openvpn-devel] [PATCH applied] Fix short-option overlapping

2017-09-29 Thread David Sommerseth
On 29/09/17 21:11, David Sommerseth wrote: > From: David Sommerseth > > Your patch has been applied to the wip branch > > commit c41c677c36a105325728a6749885060e3095e845 > Author: Antonio Quartulli > Date: Tue Sep 19 17:03:10 2017 +0800 > > Fix short-option overlapping > > Signed-o

Re: [Openvpn-devel] [PATCH v2] create_temp_file/gen_path: prevent memory leak if gc == NULL

2017-09-29 Thread Antonio Quartulli
On 30/09/17 00:10, Steffan Karger wrote: > If gc == NULL, the data allocated in the alloc_gc_buf() call in > create_temp_file or the string_mod_const call in gen_path would never > be free'd. > > These functions are currently never called that way, but let's prevent > future problems. > > While

Re: [Openvpn-devel] [PATCH 0/2] Reject client if PF plugin is configured, but init fails

2017-09-29 Thread Antonio Quartulli
On 30/09/17 00:24, Steffan Karger wrote: > This changes the behavior for pf plugins: instead of just not initializing > the firewall rules and happily continuing, this now rejects the client in > the case of an (unlikely) failure to initialize the pf. > > Signed-off-by: Steffan Karger > --- >

[Openvpn-devel] Unreferenced function in 2.4.4 Linux build

2017-09-29 Thread logcabin
In file comp-lz4.c, g++ flags LZ4_compress_default as unreferenced and the build fails. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot __