[Openvpn-devel] [PATCHv3 2/2] ensure function declarations are compiled with their definitions

2017-08-28 Thread Antonio Quartulli
From: Antonio Quartulli Function prototypes should be included when compiling their definitions so that it is clear to compilers and static analyzers that they are not static. This means that several declarations have to be moved to the related header files which in turn have to be included by t

[Openvpn-devel] [PATCH 1/2] merge *-inline.h files with their main header

2017-08-28 Thread Antonio Quartulli
*-inline.h files are not very useful anymore. In the attempt of cleaning up the code some more, merge them into their main header files. No functional change is part of this patch. Signed-off-by: Antonio Quartulli --- patch has been verified with travis-ci src/openvpn/Makefile.am

Re: [Openvpn-devel] [Openvpn-users] explicit-exit-notify is ignored by previous blocks.

2017-08-28 Thread Gert Doering
Hi, (copying in openvpn-devel as the author of the offending patch is not reading -users) On Mon, Aug 28, 2017 at 09:50:12AM +0200, Eike Lohmann wrote: > > I believe this simply infers that 'previous' "blocks" will not > > be > > effected by this _pushed_ option. > > > > It is a very dodgy mess

Re: [Openvpn-devel] [PATCH] Warn that DH config option is only meaningful in a tls-server context

2017-08-28 Thread Steffan Karger
Hi, On 27-08-17 18:15, Gert van Dijk wrote: > If specified in a tls-client context, don't try to open the file as it's > not used. Worse even, if 'none' was specified to disable explicitly, it > complained that the file 'none' could not be found. > --- > src/openvpn/options.c | 7 +++ > 1 fil

Re: [Openvpn-devel] [Openvpn-users] explicit-exit-notify is ignored by previous blocks.

2017-08-28 Thread Arne Schwabe
> > Could you throw a log that shows what the server pushes and then the > warning message (plus the client config, stripped of all sensitive stuff, > of course) into our trac? Then it won't get lost and we can go and > investigate... > > The option parser is a big chunk of magic, so it's possi

[Openvpn-devel] Reviewer for French openvpn-gui localization patch?

2017-08-28 Thread Samuli Seppänen
Hi, Could a French-speaker review this openvpn-gui pull request? It would be good to have these changes in the next OpenVPN GUI version. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock --

Re: [Openvpn-devel] Reviewer for French openvpn-gui localization patch?

2017-08-28 Thread Eric Crist
I have a few comments I'll share later when I'm back home. This mostly looks OK, but can be improved with a few clarifications and additions. Eric Crist > On Aug 28, 2017, at 7:08 AM, Samuli Seppänen wrote: > > Hi, > > Could a French-speaker review this openvpn-gui pull request? > >