Re: [Openvpn-devel] [PATCH] Deprecate --keysize

2017-08-14 Thread David Sommerseth
On 01/07/17 13:29, Steffan Karger wrote: > The --keysize option can only be used with already deprecated ciphers, > such as CAST5, RC2 or BF. Deviating from the default keysize is > generally not a good idea (see man page text), and otherwise only > complicates our code.> > (If this patch is accep

Re: [Openvpn-devel] [PATCH] Deprecate --keysize

2017-08-14 Thread Steffan Karger
Hi, On 14-08-17 12:36, David Sommerseth wrote: > On 01/07/17 13:29, Steffan Karger wrote: >> The --keysize option can only be used with already deprecated ciphers, >> such as CAST5, RC2 or BF. Deviating from the default keysize is >> generally not a good idea (see man page text), and otherwise on

Re: [Openvpn-devel] [PATCH] Deprecate --keysize

2017-08-14 Thread David Sommerseth
On 14/08/17 13:17, Steffan Karger wrote: > Hi, > > On 14-08-17 12:36, David Sommerseth wrote: >> On 01/07/17 13:29, Steffan Karger wrote: >>> The --keysize option can only be used with already deprecated ciphers, >>> such as CAST5, RC2 or BF. Deviating from the default keysize is >>> generally no

Re: [Openvpn-devel] [PATCH applied] add missing static attribute to functions

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit 72bcdfdc19243c1ed6cb8568f62f0c35e8b70f5f (master) commit d1e18d89d9ff4ce946f27d5b019c407bf750fe4b (release/2.4) Author: Antonio Quartulli Date: Fri Aug 11 17:07:42 2017 +0800 add

Re: [Openvpn-devel] [PATCH applied] Always use default keysize for NCP'd ciphers

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK. Checked code and ran a few quick local tests where it was observed that --keysize was reset to 0 when NCP was active. Your patch has been applied to the following branches commit 956bb1c32fa40ee184919b3ce569c90643a01b5b (master) commit 6f616

Re: [Openvpn-devel] [PATCH applied] Move create_temp_file() out of #ifdef ENABLE_CRYPTO

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK. This makes sense, code looks good and passes initial tests. Your patch has been applied to the following branches commit cd5a74d0d7c6347b31e261e98ca8984819e594df (master) commit a91c38fbabf6f949990ef8a3801d56225a47a33f (release/2.4) Author:

Re: [Openvpn-devel] [PATCH applied] Use provided env vars in up/down script.

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK. Verified that ${dev} does indeed exists in --up and when the plug-in runs with OPENVPN_PLUGIN_DOWN mode, which is facilitated via the down-root plug-in. Your patch has been applied to the following branches commit 94c1ce22ebcc1f672bb80598afcc

Re: [Openvpn-devel] [PATCH applied] Document down-root plugin usage in client.down

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK. Your patch has been applied to the following branches commit cbeff7b1b3f2815ee27f4479dca502c220fc4d15 (master) commit 597b6224e254775915956b8db45c090709b17b1a (release/2.4) Author: Conrad Hoffmann Date: Wed Aug 2 20:14:35 2017 +0200

Re: [Openvpn-devel] [PATCH applied] sample-plugins: fix ASN1_STRING_to_UTF8 return value checks

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK. I have a slightly modified version of this patch pending for release/2.4 (which lacks the OpenSSL 0.9.6b workaround removal). This will be considered to be added a bit later. Your patch has been applied to the master branch commit c43045ca05

Re: [Openvpn-devel] [PATCH applied] sample-plugins: fix ASN1_STRING_to_UTF8 return value checks

2017-08-14 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 This is the slightly modified commit, which resolves the merge conflict when cherry-picking the corresponding commit from git master (c43045ca059). Below is the complete commit message. commit 5ed5030c349326c5448fd87424c1a2283ccee18f (release/2.4)