[Openvpn-devel] [PATCH] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Arne Schwabe
--- src/openvpn/ssl_openssl.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 11f4a567..e1a71267 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1077,6 +1077,12 @@ tls_ctx_use_external_private

[Openvpn-devel] [PATCH v2] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Arne Schwabe
V2: Print also curve details, add missing ifdef --- src/openvpn/ssl_openssl.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 11f4a567..a8e428ea 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn

Re: [Openvpn-devel] [PATCH v2] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Steffan Karger
Hi, Conceptually fine, but the patch needs a bit more work: On 23-07-17 15:25, Arne Schwabe wrote: > V2: Print also curve details, add missing ifdef > --- > src/openvpn/ssl_openssl.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/src/openvpn/ssl_openss

[Openvpn-devel] [PATCH v3] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Arne Schwabe
V2: Print also curve details, add missing ifdef V3: Goto err instead of using M_FATAL, format fixes, use EC_GROUP_get_curve_name + OBJ_nid2sn instead of ECPKParameters_print, add compat headers for 1.0.2 --- configure.ac | 2 ++ src/openvpn/openssl_compat.h | 34

Re: [Openvpn-devel] [PATCH v3] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Steffan Karger
Hi, Thanks. This now compiles and works as expected with both OpenSSL 1.0 and 1.1. Some final nits though: On 23-07-17 17:42, Arne Schwabe wrote: > V2: Print also curve details, add missing ifdef > V3: Goto err instead of using M_FATAL, format fixes, use > EC_GROUP_get_curve_name + OBJ_nid2sn

[Openvpn-devel] [PATCH v4] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Arne Schwabe
V2: Print also curve details, add missing ifdef V3: Goto err instead of using M_FATAL, format fixes, use EC_GROUP_get_curve_name + OBJ_nid2sn instead of ECPKParameters_print, add compat headers for 1.0.2 V4: Formatting changes and change M_ERR to M_WARN --- configure.ac | 2 ++

Re: [Openvpn-devel] [PATCH v4] Print ec bit details, refuse management-external-key if key is not RSA

2017-07-23 Thread Steffan Karger
Hi, On 23-07-17 18:45, Arne Schwabe wrote: > V2: Print also curve details, add missing ifdef > V3: Goto err instead of using M_FATAL, format fixes, use > EC_GROUP_get_curve_name + OBJ_nid2sn instead of ECPKParameters_print, add > compat headers for 1.0.2 > V4: Formatting changes and change M_ERR