Re: [Openvpn-devel] [PATCH applied] Ignore auth-nocache for auth-user-pass if auth-token is pushed

2017-06-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Your patch has been applied to the following branches commit 571165360db0392fa83ec8e6f8de145f623c53fe (master) commit e4b0600c990b06ef4c94856e12b24a37110e0860 (release/2.4) Author: Antonio Quartulli Date: Sat Feb 25 08:40:14 2017 +0800 Ign

Re: [Openvpn-devel] [PATCH applied] backport: Ignore auth-nocache for auth-user-pass if auth-token is pushed

2017-06-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Your patch has been applied to the release/2.3 branch commit 199ef1321c77c43ca5151119bef65c7a3d8b716f Author: David Sommerseth Date: Sat Feb 25 14:10:29 2017 +0100 backport: Ignore auth-nocache for auth-user-pass if auth-token is pushed

[Openvpn-devel] [PATCH] Move adjust_power_of_2() to integer.h

2017-06-19 Thread Steffan Karger
misc.c it a mess of incoherent functions, and is therefore included by virtually all our source files. That makes testing harder than it should be. As a first step of cleaning up misc.c, move adjust_power_of_2() to integer.h, which is a more suitable place for a function like this. This allows u

[Openvpn-devel] [PATCH] init_key_ctx: key and iv arguments can (now) be const

2017-06-19 Thread Steffan Karger
In older OpenSSL, the key and iv arguments of EVP_CipherInit_ex() were not const, which meant that our API could not be const either. Since we dropped support for OpenSSL 0.9.8, we can now fix our internal API. Signed-off-by: Steffan Karger --- src/openvpn/crypto.c | 2 +- src/openvpn/c

Re: [Openvpn-devel] [PATCH applied] backport: Ignore auth-nocache for auth-user-pass if auth-token is pushed

2017-06-19 Thread Gert Doering
Hi, On Mon, Jun 19, 2017 at 01:11:41PM +0200, David Sommerseth wrote: > Your patch has been applied to the release/2.3 branch Uh? We were talking master and release/2.4, not release/2.3... But anyway: whatever that patch does, buildbot does not like the result - all builds have exploded, and as

[Openvpn-devel] [PATCH] auth-token with auth-nocache fix broke --disable-crypto builds

2017-06-19 Thread David Sommerseth
After adding commit 571165360db0392fa83e, it broke builds where the --disable-crypto was used with ./configure. This was due to the delayed_auth_pass_purge() which requires the crypto code paths being called from init.c without the proper #ifdef encapsulation. Signed-off-by: David Sommerseth ---

Re: [Openvpn-devel] [PATCH] auth-token with auth-nocache fix broke --disable-crypto builds

2017-06-19 Thread Gert Doering
HI, On Mon, Jun 19, 2017 at 03:05:07PM +0200, David Sommerseth wrote: > After adding commit 571165360db0392fa83e, it broke builds where > the --disable-crypto was used with ./configure. This was due to > the delayed_auth_pass_purge() which requires the crypto code paths > being called from init.c

Re: [Openvpn-devel] [PATCH] auth-token with auth-nocache fix broke --disable-crypto builds

2017-06-19 Thread David Sommerseth
On 19/06/17 15:16, Gert Doering wrote: > HI, > > On Mon, Jun 19, 2017 at 03:05:07PM +0200, David Sommerseth wrote: >> After adding commit 571165360db0392fa83e, it broke builds where >> the --disable-crypto was used with ./configure. This was due to >> the delayed_auth_pass_purge() which requires

Re: [Openvpn-devel] [PATCH applied] auth-token with auth-nocache fix broke --disable-crypto builds

2017-06-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Your patch has been applied to the following branches commit 5bde5b6d1875fd87b116c943084df0d2f6aee6d0 (master) commit df5efe7e2cd23b2282526f2c41be2063d941dff1 (release/2.4) commit 888b0dcee0e03a80f202005914b81ccb17a27eab (release/2.3) Author: Dav

Re: [Openvpn-devel] [PATCH 7/8] OpenSSL: don't use direct access to the internal of HMAC_CTX

2017-06-19 Thread Emmanuel Deloget
Hello Steffan, On Sun, Jun 18, 2017 at 1:38 PM, Steffan Karger wrote: > Hi, > > On 12-06-17 15:43, log...@free.fr wrote: > > +#if !defined(HAVE_HMAC_CTX_INIT) > > +/** > > + * Init a HMAC context > > + * > > + * @param ctx The HMAC context > > + * > > + * Contrary to many functio

Re: [Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of HMAC_CTX

2017-06-19 Thread Emmanuel Deloget
Hi Gert, On Sun, Jun 18, 2017 at 3:21 PM, Gert Doering wrote: > Your patch has been applied to the master and release/2.4 branch. > > I have not changed anything wrt _init()/reset() to not delay getting > this in-tree before the upcoming v2.4.3 release - but if you agree to > Steffan's comment o

[Openvpn-devel] [PATCH] OpenSSL: remove pre-1.1 function from the OpenSSL compat interface

2017-06-19 Thread logout
From: Emmanuel Deloget HMAC_CTX_init() has been removed from OpenSSL 1.1. Both this function and function HMAC_CTX_cleanup() has been replaced by HMAC_CTX_reset(). Commit aba98e9050eb54d72d921e70bcd422cb892b9c6c introduced support for HMAC_CTX_init() for OpenSSL 1.1+ while other functions were m

[Openvpn-devel] [PATCH] travis-ci: added gcc and clang openssl-1.1.0 builds

2017-06-19 Thread Ilya Shipitsin
openssl build script was modified according to official openssl manual: https://wiki.openssl.org/index.php/Compilation_and_Installation --- .travis.yml | 6 ++ .travis/build-deps.sh | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml i

Re: [Openvpn-devel] [PATCH] auth-token with auth-nocache fix broke --disable-crypto builds

2017-06-19 Thread Antonio Quartulli
> On 19 Jun 2017, at 21:22, David Sommerseth > wrote: > > On 19/06/17 15:16, Gert Doering wrote: >> >> Somewhat ugly (is there no existing #ifdef ENABLE_CRYPTO block nearby >> that we could hide this in?) but I need a clean tree tonight, and this >> will fix things. So, will to go with it. >