[Openvpn-devel] [PATCH] attempt to add IPv6 route even when no IPv6 address was configured

2017-01-31 Thread Antonio Quartulli
Even if no IPv6 address is configured, OpenVPN still supports transporting IPv6 segments, therefore adding an IPv6 route should always be allowed. However, the route might fail to be installed or may just not work as expected, therefore, a proper warning should be printed to inform the user of the

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-31 Thread David Sommerseth
On 30/01/17 13:34, Samuli Seppänen wrote: > I agree with you on keeping the pull request template minimal and having > the more fine-grained information in Trac. > > ACK. Don't get me wrong! I agree we should keep the template minimal. But I yet have to see a developer full of enthusiasm with

[Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-01-31 Thread Antonio Quartulli
The HTTP proxy credentials are stored in a static variable that is possibly initialized before each connection attempt. However, the variable is never "released" therefore get_user_pass() refuses to overwrite its content and leaves it as it is. Consequently, if the user config contains multiple co

Re: [Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-01-31 Thread Selva Nair
Hi, On Tue, Jan 31, 2017 at 1:22 PM, Antonio Quartulli wrote: > iff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c > index b0ed3279..27f34bed 100644 > --- a/src/openvpn/proxy.c > +++ b/src/openvpn/proxy.c > @@ -256,7 +256,16 @@ username_password_as_base64(const struct > http_proxy_info *p, >

Re: [Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-01-31 Thread Antonio Quartulli
Hi Selva, thank you very much for your feedback! On Tue, Jan 31, 2017 at 03:02:33PM -0500, Selva Nair wrote: > Hi, > > On Tue, Jan 31, 2017 at 1:22 PM, Antonio Quartulli wrote: > > > iff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c > > index b0ed3279..27f34bed 100644 > > --- a/src/openvpn