[Openvpn-devel] Topics for the upcoming (Wednesday, 4th January 2016) community meeting

Hi, We're going to have an IRC meeting on Wednesday 4th January 2016. The meeting begins at 20:00 CET (19:00 UTC) on #openvpn-meeting irc.freenode.net. You do not have to be logged in to Freenode to join the channel. Current topic list along with basic information is here:

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

On 01/01/17 18:15, Selva Nair wrote: > Hi, > > On Sun, Jan 1, 2017 at 10:49 AM, debbie10t wrote: > >> Hi, >> >> I applied this to 2.5 and used the build system to build windows >> installer using windows-nsis/build-snapshot >> >> I tested the windows client against Linux 2.4 >> >> The test was:

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

Hi, On Fri, Dec 30, 2016 at 09:45:07PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > Also make sure --dhcp-pre-release results in not just dhcp_release() > in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction > gets aborted as this call to release() happens afte

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

Hi, On Tue, Jan 3, 2017 at 12:17 PM, Gert Doering wrote: > On Fri, Dec 30, 2016 at 09:45:07PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > Also make sure --dhcp-pre-release results in not just dhcp_release() > > in open_tun() but a subsequent dhcp_renew() as well. Else dhcp >

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

On Tue, Jan 3, 2017 at 12:55 PM, Selva Nair wrote: > Hi, > > On Tue, Jan 3, 2017 at 12:17 PM, Gert Doering wrote: > >> On Fri, Dec 30, 2016 at 09:45:07PM -0500, selva.n...@gmail.com wrote: >> > From: Selva Nair >> > >> > Also make sure --dhcp-pre-release results in not just dhcp_release() >> >

[Openvpn-devel] [PATCH v2] Always release dhcp address in close_tun()

From: Selva Nair Also make sure --dhcp-pre-release results in not just dhcp_release() in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction gets aborted as this call to release() happens after the adapter status is changed to connected. Fixes Trac #807 (but can't say the sam

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

Hi, On Tue, Jan 03, 2017 at 02:36:47PM -0500, Selva Nair wrote: > > Agreed. Will send a v2 later today. > > There is one corner case that I realized only now: what > happens when a real dhcp server is in use (say in bridge mode). > Current dhcp_release() function is a no-op unless the > masquerad

[Openvpn-devel] [PATCH] Fix push options digest update

From: Selva Nair Signed-off-by: Selva Nair --- src/openvpn/push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/push.c b/src/openvpn/push.c index f515475..c9c04a6 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -692,8 +692,8 @@ push_update_digest(md

Re: [Openvpn-devel] [PATCH] Fix push options digest update

On 03-01-17 22:42, selva.n...@gmail.com wrote: > From: Selva Nair > > Signed-off-by: Selva Nair > --- > src/openvpn/push.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/push.c b/src/openvpn/push.c > index f515475..c9c04a6 100644 > --- a/src/openvpn/push.

[Openvpn-devel] [PATCH applied] Re: Fix push options digest update

Your patch has been applied to the master and release/2.4 branch. Release/2.3 does not contain the offending commit. Thanks! commit a5dbf8c8dab23c47407c3f833c4f4aae52408af1 (master) commit bf72ae68c05922c289056f2f851ed36014449cdf (release/2.4) Author: Selva Nair Date: Tue Jan 3 16:42:18 2

[Openvpn-devel] [PATCH applied] Re: Crash in options.c

ACK, thanks. Tested, fixes the issue, tracked to the offending commit (5d429efd97). Your patch has been applied to the master and release/2.4 branch. Release/2.3 does not contain the offending code. commit 49629380a7bdba25c24c9d410b79946fe29249f0 (master) commit 6650911256b2e636b4a2d754cfe60e94