Hi,
On Sat, Sep 17, 2016 at 07:11:56PM -0400, Selva Nair wrote:
> On Sat, Sep 17, 2016 at 9:20 AM, Gert Doering wrote:
>
> > In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just
> > "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32"
>
> Indeed...
>
> To depen
Hi,
On 18 September 2016 at 08:51, Lev Stipakov wrote:
> From: Lev Stipakov
>
> v5:
> * Few more nickpicks
>
> v4:
> * replace magic number with define
> * show user a decimal value instead of hex
>
> v3:
> * move assert outside of loop
> * add max-clients value check to options
>
> v2:
> * Add
Your patch has been applied to the master branch.
commit e8e1377d0fc3f11b65e415b68e6065d2e9eb836e
Author: Lev Stipakov
Date: Sun Sep 18 09:51:36 2016 +0300
Support for disabled peer-id
Acked-by: Steffan Karger
Message-Id: <1474181496-24846-1-git-send-email-lstipa...@gmail.com>
we already run openvpn/openvpn-build in travis.
build only is not complicated.
there are minor issues with 14.04 mingw gcc, which is too old for openvpn
master. I'll make patch after I will resolve it.
2016-09-17 18:58 GMT+05:00 Gert Doering :
> Hi,
> On Sat, Sep 17, 2016 at 06:40:00PM +0500, ??
ACK.
Your patch has been applied to the following branches
commit c42fcbfe708f4c97da063642cf8874f0d4d1a645 (master)
commit 1f12d8dd8a4d4efbbbf9ba9b57ee1250593268ba (release/2.3)
Author: Arne Schwabe
Date: Thu Jul 14 13:25:19 2016 +0200
Incorporate the Debian typo fixes where appropriate
In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just
"#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32"
v2: also fix block_dns.c (include config.h + compat.h) (Selva Nair)
Signed-off-by: Gert Doering
---
src/openvpn/block_dns.c | 11 +++
src/openv
Hi,
On 27 July 2016 at 16:42, Steffan Karger wrote:
> Our customers, as well as community users, have asked for encryption of
> control channel packets to hide their certificate (containing perhaps
> the users' name or organisation), or to provide some basic form of
> post-quantum security (see e
---
src/openvpn/buffer.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c
index 52c6ab9..57bded9 100644
--- a/src/openvpn/buffer.c
+++ b/src/openvpn/buffer.c
@@ -438,10 +438,12 @@ format_hex_ex (const uint8_t *data, int size, int
On Sun, Sep 18, 2016 at 2:59 AM, Gert Doering wrote:
> Ah. Here we go... trying to redefine WIN32 at the end of syshead.h
> shows what is happening:
>
> In file included from /usr/share/mingw-w64/include/windef.h:8:0,
> from /usr/share/mingw-w64/include/windows.h:69,
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 18/09/16 17:19, Ilya Shipitsin wrote:
> --- src/openvpn/buffer.c | 6 -- 1 file changed, 4
> insertions(+), 2 deletions(-)
>
> diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c index
> 52c6ab9..57bded9 100644 --- a/src/openvpn/buffer.c
Hi,
On Sun, Sep 18, 2016 at 06:14:09PM +0300, David Sommerseth wrote:
> This looks dangerous and somewhat wrong. This can actually stop a
> server completely if the ASSERT() check fails. I'm not sure we want
> to do that.
This was discussed in a github PR, but I do not have the number right
now
Hello,
this defect was found by cppcheck, however cppcheck still complains.
so, we did not make it happy yet.
I think, the best would be split this function into 2 separate functions
(with either null argument) or leave it like that.
2016-09-18 20:14 GMT+05:00 David Sommerseth <
open...@sf.lists
>
> Hello,
>
> this defect was found by cppcheck, however cppcheck still complains.
> so, we did not make it happy yet.
>
> I think, the best would be split this function into 2 separate functions
> (with either null argument) or leave it like that.
Unrelated to an actual fix, IMHO we should at
Hi,
On Sun, Sep 18, 2016 at 8:14 AM, Gert Doering wrote:
> In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just
> "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32"
>
> v2: also fix block_dns.c (include config.h + compat.h) (Selva Nair)
>
> Signed-off-by: Gert
Hi,
On Sun, Sep 18, 2016 at 8:25 AM, Steffan Karger wrote:
> Hi,
>
> On 27 July 2016 at 16:42, Steffan Karger
> wrote:
> > Our customers, as well as community users, have asked for encryption of
> > control channel packets to hide their certificate (containing perhaps
> > the users' name or org
Patch has been applied to the master branch.
commit 6cd7e08d89cc9c39d00989866fb4782d5e7041dc
Author: Gert Doering
Date: Sun Sep 18 14:14:23 2016 +0200
Fix win32 building with C99 mode
Signed-off-by: Gert Doering
Acked-by: Selva Nair
Message-Id: <20160918121423.52139-1-g..
Hi,
On Sun, Sep 18, 2016 at 10:20:16AM -0400, Selva Nair wrote:
> Yeah, to me that only confirms my feeling that #ifdef WIN32 is not
> reliable. Much better to use _WIN32 which appears to be defined by all (?)
> C compilers that support windows and doesn't require any particular header
> to be inc
17 matches
Mail list logo
