Another ACK from me, looks good (and works :) )...
Mon Jul 11 16:30:28 2016 us=977593 Restart pause, 2 second(s)
Mon Jul 11 16:30:32 2016 us=937071 Restart pause, 2 second(s)
Mon Jul 11 16:30:36 2016 us=957047 Restart pause, 2 second(s)
Mon Jul 11 16:30:40 2016 us=907049 Restart pause, 2 second(s)
Before the connect-retry change to do exponential backup this was not necessary
since the time was fixed. With the exponential backoff the UI needs either to
implement its own exponential backoff mechansim or needs a way of knowing the
value of OpenVPN internal mechansim.
---
doc/management-notes.
---
doc/android.txt | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/doc/android.txt b/doc/android.txt
index 137edfc..3a096dd 100644
--- a/doc/android.txt
+++ b/doc/android.txt
@@ -2,7 +2,7 @@ This file documents the support in OpenVPN for Android 4.0 and
up.
This
ACK. Reviewed the patch before - performance impact is not high
(compared to exec()'ing netsh.exe), and I can see the argument that
the approach I suggested would be changing too many different places
to be more "clean". Compile-tested, not run.
Your patch has been applied to the master and rele
ACK. Gone with the wind.
In the post-2.4 series, we might consider throwing out the automatic
part totally...
Your patch has been applied to the master branch.
commit 6dd307c8640d851c6241a27f434c53a6aee0cace
Author: Samuli Seppänen
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Jul
ACK. Just assuming that you know your URLs and management commands :)
(no code change).
Your patch has been applied to the master branch.
commit 49817bf0ad599b8f9e8d52be9c0bb007aece0d48
Author: Arne Schwabe
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Jul 11 16:50:59 2016 +0200
Another ACK from me. Stared at the code for another while, still looks
reasonable. Passes my t_client tests, t_server tests, and does not
break Android :-)
Your patch has been applied to the master branch.
commit 97894360fa537945e07fd6a85d0659e094b693a5
Author: Steffan Karger
List-Post: openv
Hi,
On Mon, Jul 11, 2016 at 10:50 AM, Arne Schwabe wrote:
> Before the connect-retry change to do exponential backup this was not
> necessary
> since the time was fixed. With the exponential backoff the UI needs either
> to
> implement its own exponential backoff mechansim or needs a way of know
Another ACK from me. This is fairly trivial (compared to 3/5, at least).
As a side note: as discussed on IRC, the extra copy of ciphername and
authname in c1.* is needed because "this is what is in the initial config"
and the variables in "options->*" might be overwritten by PUSH_REPLY
(I was con
