Re: [Openvpn-devel] [PATCH v2] Drop recursively routed packets

2016-06-11 Thread Gert Doering
Hi, On Wed, Apr 06, 2016 at 11:44:34PM +0300, ValdikSS wrote: > More like a notification not to forget about it. I'll test it tomorrow and > write the results. > > On 06.04.2016 17:51, Gert Doering wrote: > > Hi, > > > > On Wed, Apr 06, 2016 at 02:37:13PM +0300, ValdikSS wrote: > > Is this a "I

Re: [Openvpn-devel] [PATCHv2] Complete push-peer-info documentation and allow IV_PLAT_VER for other platforms than Windows if the client UI supplies it.

2016-06-11 Thread Gert Doering
Hi, On Tue, Feb 16, 2016 at 01:04:40PM +0100, Arne Schwabe wrote: > diff --git a/doc/openvpn.8 b/doc/openvpn.8 > index 5a4efc6..d99aaf5 100644 > --- a/doc/openvpn.8 > +++ b/doc/openvpn.8 ... took me long enough, but ACK. I've change the wording related to IV_NCP=2 a bit - there was a typo, and I

Re: [Openvpn-devel] [PATCH V2] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Gert Doering
Hi, On Thu, Oct 15, 2015 at 04:38:32PM +0200, Arne Schwabe wrote: > With this change all timeouts before the first packet from the OpenVPN server > are unified into the server-poll-timeout option. Time to get this done... > The default of 120s has been chosen to be a safe value is larger as it

Re: [Openvpn-devel] [PATCH V2] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Arne Schwabe
Am 11.06.16 um 14:10 schrieb Gert Doering: > This check "c2.tls_multi" - is this a short form for "we're not a > peer-to-peer session"? > > Other parts of the code seem to check "we have --pull or we have > --mode server", so I wonder if we should make this somewhat more > uninform. Eventuall

[Openvpn-devel] [[PATCH v3]] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Arne Schwabe
With this change all timeouts before the first packet from the OpenVPN server are unified into the server-poll-timeout option. The default of 120s has been chosen to be a safe value is larger as it is larger the sums of the old small timeouts. V3: fix some whitespace/typos problems --- doc/ope

Re: [Openvpn-devel] [PATCH V2] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Gert Doering
Hi, On Sat, Jun 11, 2016 at 04:29:27PM +0200, Arne Schwabe wrote: > Am 11.06.16 um 14:10 schrieb Gert Doering: > > This check "c2.tls_multi" - is this a short form for "we're not a > > peer-to-peer session"? > > > > Other parts of the code seem to check "we have --pull or we have > > --mode s

Re: [Openvpn-devel] [[PATCH v3]] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Gert Doering
Hi, On Sat, Jun 11, 2016 at 04:43:15PM +0200, Arne Schwabe wrote: > With this change all timeouts before the first packet from the OpenVPN server > are unified into the server-poll-timeout option. > > The default of 120s has been chosen to be a safe value is larger as it is > larger the sums of

[Openvpn-devel] [PATCH applied] Re: ] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Gert Doering
ACK. Stared at the code for a while, and went out testing it (also, we got a feature-ACK for that waaay back in Munich already). I have added a note to Changes.rst explaining the change, and how to get back the old default behaviour of a 10s timeout on TCP connects. Your patch has been applied t

Re: [Openvpn-devel] [[PATCH v3]] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Selva Nair
On Sat, Jun 11, 2016 at 2:14 PM, Gert Doering wrote: > One thing I noticed when testing which is not *caused* by this patch but > which you/we might want to fix while at it. > > When talking to a "deaf" HTTP proxy - namely, one that accepts the TCP > connect, but then never sends back anything (t

Re: [Openvpn-devel] [[PATCH v3]] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Gert Doering
Hi, On Sat, Jun 11, 2016 at 02:47:47PM -0400, Selva Nair wrote: > Isn't this controlled by the http-proxy-retry option which is off by > default? Set that in the config and SIGUSR1 restart should happen, I > think... Right you are, and ditto for --socks-proxy-retry. Sat Jun 11 22:23:50 2016 Atte

Re: [Openvpn-devel] [[PATCH v3]] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-11 Thread Selva Nair
On Sat, Jun 11, 2016 at 4:26 PM, Gert Doering wrote: > On Sat, Jun 11, 2016 at 02:47:47PM -0400, Selva Nair wrote: > > Isn't this controlled by the http-proxy-retry option which is off by > > default? Set that in the config and SIGUSR1 restart should happen, I > > think... > > Right you are, and